issue_comments

Table actions

2 rows where author_association = "OWNER", issue = 1408561039 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 2 ✖

issue 1

  • check_visibility can now take multiple permissions into account · 2 ✖

author_association 1

  • OWNER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1288311852 https://github.com/simonw/datasette/pull/1842#issuecomment-1288311852 https://api.github.com/repos/simonw/datasette/issues/1842 IC_kwDOBm6k_c5MyhQs simonw 9599 2022-10-24T02:11:12Z 2022-10-24T02:11:12Z OWNER

I'm going to construct a metadata.yml which makes various databases and tables visible or invisible, then browse them using the root user.

block-instance.yml:

yaml allow: id: root block-database.yml: yaml databases: fixtures: allow: id: root block-table.yml: yaml databases: fixtures: tables: searchable: allow: id: root block-query.yml: yaml databases: fixtures: queries: two: sql: select 1 + 1 allow: id: root https://gist.github.com/simonw/2d007ebe43de46d44499c77a2a291756 - checkout that Gist to get all four.

I manually tested all four scenarios with root and non-root users and confirmed that they worked correctly and padlocks were shown in the right places.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 check_visibility can now take multiple permissions into account 1408561039  
1288304224 https://github.com/simonw/datasette/pull/1842#issuecomment-1288304224 https://api.github.com/repos/simonw/datasette/issues/1842 IC_kwDOBm6k_c5MyfZg simonw 9599 2022-10-24T02:00:14Z 2022-10-24T02:00:14Z OWNER

I need to do one last round of manual testing before I merge this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 check_visibility can now take multiple permissions into account 1408561039  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);