issue_comments

Table actions

4 rows where author_association = "OWNER", issue = 1423364990 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 4 ✖

issue 1

  • `max_signed_tokens_ttl` setting for a maximum duration on API tokens · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1292709818 https://github.com/simonw/datasette/issues/1858#issuecomment-1292709818 https://api.github.com/repos/simonw/datasette/issues/1858 IC_kwDOBm6k_c5NDS-6 simonw 9599 2022-10-26T22:07:04Z 2022-10-26T22:07:04Z OWNER

New token design:

json { "a": "actor-id", "t": "creation timestamp as integer", "d": "intended duration in seconds, or blank if no duration set" } This is in place of the "e": "expiry timestamp" design I've built so far.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `max_signed_tokens_ttl` setting for a maximum duration on API tokens 1423364990  
1292708227 https://github.com/simonw/datasette/issues/1858#issuecomment-1292708227 https://api.github.com/repos/simonw/datasette/issues/1858 IC_kwDOBm6k_c5NDSmD simonw 9599 2022-10-26T22:05:34Z 2022-10-26T22:05:34Z OWNER

I just realized this can't easily affect the datasette create-token command because it doesn't currently accept the --setting option, so it wouldn't know what max_signed_tokens_ttl was.

More to the point: even if it did, someone could abuse their knowledge of the secret to create a signed non-expiring token even on servers that didn't want to support those.

So I actually need to redesign the token format: it needs to store the timestamp when the token was created and the intended duration, NOT the timestamp that the token expires at.

Otherwise it's not possible for servers to enforce max_signed_tokens_ttl - someone could always create a token with a custom expires_at timestamp on it outside of the configured limit.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `max_signed_tokens_ttl` setting for a maximum duration on API tokens 1423364990  
1292687774 https://github.com/simonw/datasette/issues/1858#issuecomment-1292687774 https://api.github.com/repos/simonw/datasette/issues/1858 IC_kwDOBm6k_c5NDNme simonw 9599 2022-10-26T21:44:57Z 2022-10-26T21:44:57Z OWNER

I'm going for consistency with max_csv_mb and max_returned_rows and allow_signed_tokens and default_cache_ttl.

So max_signed_tokens_ttl.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `max_signed_tokens_ttl` setting for a maximum duration on API tokens 1423364990  
1291435464 https://github.com/simonw/datasette/issues/1858#issuecomment-1291435464 https://api.github.com/repos/simonw/datasette/issues/1858 IC_kwDOBm6k_c5M-b3I simonw 9599 2022-10-26T03:07:16Z 2022-10-26T03:07:16Z OWNER

This setting will disable the "Token never expires" option:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 `max_signed_tokens_ttl` setting for a maximum duration on API tokens 1423364990  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);