issue_comments

Table actions

2 rows where author_association = "OWNER", issue = 1426379903 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date)

user 1

  • simonw · 2 ✖

issue 1

  • don't use immutable=1, only mode=ro · 2 ✖

author_association 1

  • OWNER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1295660092 https://github.com/simonw/datasette/pull/1870#issuecomment-1295660092 https://api.github.com/repos/simonw/datasette/issues/1870 IC_kwDOBm6k_c5NOjQ8 simonw 9599 2022-10-29T00:25:26Z 2022-10-29T00:25:26Z OWNER

Saw your comment here too: https://github.com/simonw/datasette/issues/1480#issuecomment-1271101072

switching from immutable=1 to mode=ro completely addressed this. see https://github.com/simonw/datasette/issues/1836#issuecomment-1271100651 for details.

So maybe we need a special case for containers that are intended to be run using Docker - the ones produced by datasette package and datasette publish cloudrun? Those are cases where the -i option should actually be opened in read-only mode, not immutable mode.

Maybe a datasette serve --irw data.db option for opening a file in immutable-but-actually-read-only mode? Bit ugly though.

I should run some benchmarks to figure out if immutable really does offer significant performance benefits.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 don't use immutable=1, only mode=ro 1426379903  
1295657771 https://github.com/simonw/datasette/pull/1870#issuecomment-1295657771 https://api.github.com/repos/simonw/datasette/issues/1870 IC_kwDOBm6k_c5NOisr simonw 9599 2022-10-29T00:19:03Z 2022-10-29T00:19:03Z OWNER

Just saw your comment here: https://github.com/simonw/datasette/issues/1836#issuecomment-1272357976

when you are running from docker, you always will want to run as mode=ro because the same thing that is causing duplication in the inspect layer will cause duplication in the final container read/write layer when datasette serve runs.

I don't understand this. My mental model of how Docker works is that the image itself is created using docker build... but then when the image runs later on (docker run) the image itself isn't touched at all.

Are you saying that I can build a container, but then when I run it and it does datasette serve -i data.db ... it will somehow modify the image, or create a new modified filesystem layer in the runtime environment, as a result of running that serve command?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 don't use immutable=1, only mode=ro 1426379903  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);