issue_comments

Table actions

4 rows where author_association = "OWNER" and issue = 1452364777 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Extract logic for resolving a URL to a database / table / row · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1320616559 https://github.com/simonw/datasette/issues/1896#issuecomment-1320616559 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5OtwJv simonw 9599 2022-11-18T22:51:14Z 2022-11-18T22:51:14Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Extract logic for resolving a URL to a database / table / row 1452364777  
1320588299 https://github.com/simonw/datasette/issues/1896#issuecomment-1320588299 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5OtpQL simonw 9599 2022-11-18T22:16:59Z 2022-11-18T22:17:06Z OWNER

Found myself needing an await db.view_exists() method for this, similar to the existing await db.table_exists() one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Extract logic for resolving a URL to a database / table / row 1452364777  
1317757949 https://github.com/simonw/datasette/issues/1896#issuecomment-1317757949 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5Oi2P9 simonw 9599 2022-11-16T22:27:47Z 2022-11-18T21:48:29Z OWNER

Open question: should resolve_table() know how to identify named canned queries too?

I think not, at least for the moment. Feels a bit too specialist to expose in a documented API.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Extract logic for resolving a URL to a database / table / row 1452364777  
1317757112 https://github.com/simonw/datasette/issues/1896#issuecomment-1317757112 https://api.github.com/repos/simonw/datasette/issues/1896 IC_kwDOBm6k_c5Oi2C4 simonw 9599 2022-11-16T22:26:52Z 2022-11-16T22:33:13Z OWNER

Some ideas from walking the dog:

Challenge: standard URL routing of request to database/table/row

Standardize on the named components of the URL patterns - database, table, pks

Async function that takes the request and the Datasette instance and returns a Resolved instance with: .level - database or table or row (better name?) .database - the name of the database .db - the database object .table - the name of the table (or view) .is_view perhaps? .pk_values if it's a row Should this attempt to resolve names queries too? ``` .where_sql - the where fragment you use .where_params - accompanying dictionary

await datasette.resolve_request(request) Or even better three methods:python datasette.resolve_database(request) datasette.resolve_table(request) datasette.resolve_row(request) ``` These can be typed correctly

Methods raise NotFound if not found

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Extract logic for resolving a URL to a database / table / row 1452364777  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);