issue_comments

Table actions

2 rows where author_association = "OWNER" and issue = 1515815014 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • render_cell plugin hook's row object is not a sqlite.Row · 2 ✖

author_association 1

  • OWNER · 2 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1368936146 https://github.com/simonw/datasette/issues/1973#issuecomment-1368936146 https://api.github.com/repos/simonw/datasette/issues/1973 IC_kwDOBm6k_c5RmE7S simonw 9599 2023-01-02T13:13:03Z 2023-01-02T13:13:03Z OWNER

It's quite handy that the label for foreign keys is made available to the custom render function here - if that was properly documented (and maybe had a slightly more intuitive API) I think it might be a good solution here.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 render_cell plugin hook's row object is not a sqlite.Row 1515815014  
1368935320 https://github.com/simonw/datasette/issues/1973#issuecomment-1368935320 https://api.github.com/repos/simonw/datasette/issues/1973 IC_kwDOBm6k_c5RmEuY simonw 9599 2023-01-02T13:12:00Z 2023-01-02T13:12:00Z OWNER

Thanks for catching this!

Definitely a bug. This might be a good opportunity to reconsider how his should work though.

It's possible that Datasette will eventually support alternative database backends - PostgreSQL, DuckDB and ClickHouse are all on my radar here.

If that happens, this plugin hook returning a SQLite Row wouldn't make sense.

Some kind of thing abstraction layer - maybe CustomRow, maybe something a little bit better - might be a good idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 render_cell plugin hook's row object is not a sqlite.Row 1515815014  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);