issue_comments

Table actions

4 rows where author_association = "OWNER" and issue = 1651082214 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

issue 1

  • feat: Javascript Plugin API (Custom panels, column menu items with JS actions) · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1760552652 https://github.com/simonw/datasette/pull/2052#issuecomment-1760552652 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5o7-bM simonw 9599 2023-10-12T23:59:21Z 2023-10-12T23:59:21Z OWNER

I'm landing this despite the cog failures. I'll fix them on main if I have to.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  
1760545012 https://github.com/simonw/datasette/pull/2052#issuecomment-1760545012 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5o78j0 simonw 9599 2023-10-12T23:48:16Z 2023-10-12T23:48:16Z OWNER

Oh! I think I broke Cog on main and these tests are running against this branch rebased against main.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  
1760542865 https://github.com/simonw/datasette/pull/2052#issuecomment-1760542865 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5o78CR simonw 9599 2023-10-12T23:44:53Z 2023-10-12T23:45:15Z OWNER

Weird, the cog check is failing in CI.

Run cog --check docs/*.rst cog --check docs/*.rst shell: /usr/bin/bash -e {0} env: pythonLocation: /opt/hostedtoolcache/Python/3.9.18/x64 PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib/pkgconfig Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64 Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64 Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.9.18/x64 LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.9.18/x64/lib Check failed Checking docs/authentication.rst Checking docs/binary_data.rst Checking docs/changelog.rst Checking docs/cli-reference.rst Checking docs/configuration.rst (changed)

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  
1629337927 https://github.com/simonw/datasette/pull/2052#issuecomment-1629337927 https://api.github.com/repos/simonw/datasette/issues/2052 IC_kwDOBm6k_c5hHblH simonw 9599 2023-07-10T16:43:38Z 2023-07-10T16:44:23Z OWNER

I tried running this locally just now. I made one edit: diff diff --git a/demos/plugins/example_js_manager_plugins.py b/demos/plugins/example_js_manager_plugins.py index 7bdb9f3f..f9dfa8e6 100644 --- a/demos/plugins/example_js_manager_plugins.py +++ b/demos/plugins/example_js_manager_plugins.py @@ -15,6 +15,6 @@ def extra_js_urls(view_name): if view_name in PERMITTED_VIEWS: return [ { - "url": f"/-/demos/plugins/static/table-example-plugins.js", + "url": f"/static/table-example-plugins.js", } ] And then started it running like this: bash wget https://datasette.io/content.db bash datasette content.db \ --plugins-dir demos/plugins \ --static static:datasette/demos/plugins/static

It didn't quite work for me - I got this error on a table page:

And this error on a query page:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 feat: Javascript Plugin API (Custom panels, column menu items with JS actions) 1651082214  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);