issue_comments

Table actions

5 rows where author_association = "OWNER" and issue = 1822934563 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Plan for getting the new JSON format query views working · 5 ✖

author_association 1

  • OWNER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1652721111 https://github.com/simonw/datasette/issues/2109#issuecomment-1652721111 https://api.github.com/repos/simonw/datasette/issues/2109 IC_kwDOBm6k_c5igoXX simonw 9599 2023-07-27T00:23:28Z 2023-07-27T00:23:37Z OWNER

Once again I'm tempted to formalize the extra HTML context as a dataclass so I can ensure it is documented correctly.

Here's an example of Hugging Face doing that: https://github.com/huggingface/transformers/blob/1689aea73346816b936b84932e12b774974e61a6/src/transformers/training_args.py#L622C1-L624

```python from dataclasses import dataclass, field

@dataclass class TrainingArguments: output_dir: str = field( metadata={"help": "The output directory where the model predictions and checkpoints will be written."}, ) ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plan for getting the new JSON format query views working 1822934563  
1652715823 https://github.com/simonw/datasette/issues/2109#issuecomment-1652715823 https://api.github.com/repos/simonw/datasette/issues/2109 IC_kwDOBm6k_c5ignEv simonw 9599 2023-07-27T00:17:04Z 2023-07-27T00:18:07Z OWNER

New decision: I had originally decided that the HTML view would just use data that could otherwise be extracted from the JSON view if you fed in enough extras.

I've changed my mind. I'm OK with the HTML view getting a few bonus things available in its context, provided those are clearly documented for template authors.

This should help avoid me having to make many changes to the templates themselves.

HTML-specific stuff will be things like csrftoken() and edit_sql_url and show_hide_link and database_color and suchlike.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plan for getting the new JSON format query views working 1822934563  
1652325193 https://github.com/simonw/datasette/issues/2109#issuecomment-1652325193 https://api.github.com/repos/simonw/datasette/issues/2109 IC_kwDOBm6k_c5ifHtJ simonw 9599 2023-07-26T18:51:15Z 2023-07-26T18:51:15Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plan for getting the new JSON format query views working 1822934563  
1652295866 https://github.com/simonw/datasette/issues/2109#issuecomment-1652295866 https://api.github.com/repos/simonw/datasette/issues/2109 IC_kwDOBm6k_c5ifAi6 simonw 9599 2023-07-26T18:26:18Z 2023-07-26T18:26:18Z OWNER

I'm going to do this work in a fresh branch, copying bits over from here as needed: - https://github.com/simonw/datasette/pull/2053

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plan for getting the new JSON format query views working 1822934563  
1652294920 https://github.com/simonw/datasette/issues/2109#issuecomment-1652294920 https://api.github.com/repos/simonw/datasette/issues/2109 IC_kwDOBm6k_c5ifAUI simonw 9599 2023-07-26T18:25:34Z 2023-07-26T18:25:34Z OWNER

OK, these issues will do for the plan.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Plan for getting the new JSON format query views working 1822934563  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);