issue_comments

Table actions

7 rows where author_association = "OWNER", issue = 1841501975 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • simonw · 7 ✖

issue 1

  • [feature request]`datasette install plugins.json` options · 7 ✖

author_association 1

  • OWNER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1672224611 https://github.com/simonw/datasette/issues/2133#issuecomment-1672224611 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jrB9j simonw 9599 2023-08-09T22:07:43Z 2023-08-09T22:07:43Z OWNER 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  
1672076671 https://github.com/simonw/datasette/issues/2133#issuecomment-1672076671 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jqd1_ simonw 9599 2023-08-09T20:09:31Z 2023-08-09T20:09:31Z OWNER

I'm going to have it only return plugins with a version other than None.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  
1672076284 https://github.com/simonw/datasette/issues/2133#issuecomment-1672076284 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jqdv8 simonw 9599 2023-08-09T20:09:12Z 2023-08-09T20:09:12Z OWNER

Problem - if there are plugins in the plugins directory it was returning this: messages_output_renderer.py==None my_plugin.py==None my_plugin_2.py==None register_output_renderer.py==None sleep_sql_function.py==None view_name.py==None

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  
1671722482 https://github.com/simonw/datasette/issues/2133#issuecomment-1671722482 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jpHXy simonw 9599 2023-08-09T16:06:28Z 2023-08-09T16:06:28Z OWNER

Plugin configuration itself currently lives in metadata.json which I don't like - that file was supposed to be for metadata about your databases, it's a bit of an accident that it grew configuration options as well.

I'm hoping to fix that for Datasette 1.0, but I'm still figuring out how to do that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  
1671720761 https://github.com/simonw/datasette/issues/2133#issuecomment-1671720761 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jpG85 simonw 9599 2023-08-09T16:05:33Z 2023-08-09T16:05:33Z OWNER

Honestly the --all option isn't particularly useful - it's really more of a debugging tool for myself than something that I expect anyone else to use.

The purpose of datasette plugins generally is to help people confirm that plugins installed correctly. It's effectively the CLI alternative to hitting https://datasette.io/-/plugins

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  
1671634654 https://github.com/simonw/datasette/issues/2133#issuecomment-1671634654 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jox7e simonw 9599 2023-08-09T15:32:14Z 2023-08-09T15:32:14Z OWNER

```diff diff --git a/datasette/cli.py b/datasette/cli.py index 32266888..370b722c 100644 --- a/datasette/cli.py +++ b/datasette/cli.py @@ -223,15 +223,22 @@ pm.hook.publish_subcommand(publish=publish)

@cli.command() @click.option("--all", help="Include built-in default plugins", is_flag=True) +@click.option( + "--requirements", help="Output requirements.txt of installed plugins", is_flag=True +) @click.option( "--plugins-dir", type=click.Path(exists=True, file_okay=False, dir_okay=True), help="Path to directory containing custom plugins", ) -def plugins(all, plugins_dir): +def plugins(all, requirements, plugins_dir): """List currently installed plugins""" app = Datasette([], plugins_dir=plugins_dir) - click.echo(json.dumps(app._plugins(all=all), indent=4)) + if requirements: + for plugin in app._plugins(): + click.echo("{}=={}".format(plugin["name"], plugin["version"])) + else: + click.echo(json.dumps(app._plugins(all=all), indent=4))

@cli.command() Output: % datasette plugins --requirements
datasette-codespaces==0.1.1 datasette-graphql==2.2 datasette-json-html==1.0.1 datasette-pretty-json==0.2.2 datasette-x-forwarded-host==0.1 ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  
1671628602 https://github.com/simonw/datasette/issues/2133#issuecomment-1671628602 https://api.github.com/repos/simonw/datasette/issues/2133 IC_kwDOBm6k_c5jowc6 simonw 9599 2023-08-09T15:28:42Z 2023-08-09T15:28:42Z OWNER

Neat idea! We already have this command:

datasette install -r requirements.txt

So maybe datasetet plugins --requirements could generate a requirements.txt file which could be used there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 [feature request]`datasette install plugins.json` options 1841501975  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);