issue_comments

Table actions

8 rows where author_association = "OWNER", issue = 273846123 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 8 ✖

issue 1

  • datasette publish heroku · 8 ✖

author_association 1

  • OWNER · 8 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
350521736 https://github.com/simonw/datasette/issues/90#issuecomment-350521736 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM1MDUyMTczNg== simonw 9599 2017-12-10T03:06:34Z 2017-12-10T03:06:34Z OWNER

Heroku is now in the README as of 6bdfcf60760c27e29ff34692d06e62b36aeecc56

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
350521711 https://github.com/simonw/datasette/issues/90#issuecomment-350521711 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM1MDUyMTcxMQ== simonw 9599 2017-12-10T03:05:48Z 2017-12-10T03:05:48Z OWNER

I fixed that last issue in c195ee4d46f2577b1943836a8270d84c8341d138

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
346163513 https://github.com/simonw/datasette/issues/90#issuecomment-346163513 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM0NjE2MzUxMw== simonw 9599 2017-11-21T21:16:16Z 2017-11-21T21:16:16Z OWNER

The reason relative paths work for publish now is that the make_dockerfile() function is called by passing the file names, not the full file paths:

https://github.com/simonw/datasette/blob/e47117ce1d15f11246a3120aa49de70205713d05/datasette/utils.py#L166

Clearly the correct thing to do here is for us to refactor the shared code between heroku/package/now.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
346161985 https://github.com/simonw/datasette/issues/90#issuecomment-346161985 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM0NjE2MTk4NQ== simonw 9599 2017-11-21T21:10:22Z 2017-11-21T21:10:22Z OWNER

Woohoo!

I've found one tiny issue: right now, the following doesn't work:

datasette publish heroku ../demo-databses/google-trends.db

It results in this error in the Heroku logs:

2017-11-21T21:03:29.210511+00:00 app[web.1]: Usage: datasette serve [OPTIONS] [FILES]...
2017-11-21T21:03:29.210524+00:00 app[web.1]: 
2017-11-21T21:03:29.210555+00:00 app[web.1]: Error: Invalid value for "files": Path "../demo-databses/google-trends.db" does not exist.

The command works fine if you run it in the same directory as the database file you are publishing.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
344687328 https://github.com/simonw/datasette/issues/90#issuecomment-344687328 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM0NDY4NzMyOA== simonw 9599 2017-11-15T18:39:14Z 2017-11-15T18:39:49Z OWNER

By default the command could use a temporary directory that gets cleaned up after the deploy, but we could allow users to opt in to keeping the generated directory like so:

datasette publish heroku mydb.py -d ~/dev/my-heroku-app

This would create the my-heroku-app folder so you can later execute further git deploys from there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
344686483 https://github.com/simonw/datasette/issues/90#issuecomment-344686483 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM0NDY4NjQ4Mw== simonw 9599 2017-11-15T18:36:23Z 2017-11-15T18:36:23Z OWNER

The “datasette build” command would need to run in a bin/post_compile script eg https://github.com/simonw/simonwillisonblog/blob/cloudflare-ips/bin/post_compile

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
344680385 https://github.com/simonw/datasette/issues/90#issuecomment-344680385 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM0NDY4MDM4NQ== simonw 9599 2017-11-15T18:14:11Z 2017-11-15T18:14:11Z OWNER

Maybe we don’t even need a buildpack... we could create a temporary directory, set up a classic heroku app with the datasette serve command in the Procfile and then git push to deploy.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  
344667202 https://github.com/simonw/datasette/issues/90#issuecomment-344667202 https://api.github.com/repos/simonw/datasette/issues/90 MDEyOklzc3VlQ29tbWVudDM0NDY2NzIwMg== simonw 9599 2017-11-15T17:29:38Z 2017-11-15T17:29:38Z OWNER

@jacobian points out that a buildpack may be a better fit than a Docker container for implementing this: https://twitter.com/jacobian/status/930849058465255424

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish heroku 273846123  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);