issue_comments

Table actions

6 rows where author_association = "OWNER" and issue = 314506446 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Ability for plugins to define extra JavaScript and CSS · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
382048582 https://github.com/simonw/datasette/issues/214#issuecomment-382048582 https://api.github.com/repos/simonw/datasette/issues/214 MDEyOklzc3VlQ29tbWVudDM4MjA0ODU4Mg== simonw 9599 2018-04-17T16:04:42Z 2018-04-18T02:24:46Z OWNER

One possible option: let plugins bundle their own static/ directory and then register themselves with Datasette, then have /-/static-plugins/name-of-plugin/... serve files from that directory.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for plugins to define extra JavaScript and CSS 314506446  
382069980 https://github.com/simonw/datasette/issues/214#issuecomment-382069980 https://api.github.com/repos/simonw/datasette/issues/214 MDEyOklzc3VlQ29tbWVudDM4MjA2OTk4MA== simonw 9599 2018-04-17T17:08:28Z 2018-04-17T17:08:28Z OWNER

Even if we automatically serve ALL static/ content from installed plugins, we'll still need them to register which files need to be linked to from extra_css_urls and extra_js_urls

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for plugins to define extra JavaScript and CSS 314506446  
382038613 https://github.com/simonw/datasette/issues/214#issuecomment-382038613 https://api.github.com/repos/simonw/datasette/issues/214 MDEyOklzc3VlQ29tbWVudDM4MjAzODYxMw== simonw 9599 2018-04-17T15:38:23Z 2018-04-17T15:38:23Z OWNER

I figured out the recipe for bundling static assets in a plugin: https://github.com/simonw/datasette-plugin-demos/commit/26c5548f4ab7c6cc6d398df17767950be50d0edf (and then python3 setup.py bdist_wheel)

Having done that, I ran pip install ../datasette-plugin-demos/dist/datasette_plugin_demos-0.2-py3-none-any.whl from my Datasette virtual environment and then did the following:

```

import pkg_resources pkg_resources.resource_stream( ... 'datasette_plugin_demos', 'static/plugin.js' ... ).read() b"alert('hello');\n" pkg_resources.resource_filename( ... 'datasette_plugin_demos', 'static/plugin.js' ... ) '..../venv/lib/python3.6/site-packages/datasette_plugin_demos/static/plugin.js' pkg_resources.resource_string( ... 'datasette_plugin_demos', 'static/plugin.js' ... ) b"alert('hello');\n" ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for plugins to define extra JavaScript and CSS 314506446  
381612585 https://github.com/simonw/datasette/issues/214#issuecomment-381612585 https://api.github.com/repos/simonw/datasette/issues/214 MDEyOklzc3VlQ29tbWVudDM4MTYxMjU4NQ== simonw 9599 2018-04-16T14:10:16Z 2018-04-16T14:10:16Z OWNER

resource_stream returns a file-like object which may be better for serving from Sanic.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for plugins to define extra JavaScript and CSS 314506446  
381491707 https://github.com/simonw/datasette/issues/214#issuecomment-381491707 https://api.github.com/repos/simonw/datasette/issues/214 MDEyOklzc3VlQ29tbWVudDM4MTQ5MTcwNw== simonw 9599 2018-04-16T06:21:23Z 2018-04-16T06:21:23Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for plugins to define extra JavaScript and CSS 314506446  
381490361 https://github.com/simonw/datasette/issues/214#issuecomment-381490361 https://api.github.com/repos/simonw/datasette/issues/214 MDEyOklzc3VlQ29tbWVudDM4MTQ5MDM2MQ== simonw 9599 2018-04-16T06:13:02Z 2018-04-16T06:13:02Z OWNER

Packaging JS and CSS in a pip installable wheel is fiddly but possible. http://peak.telecommunity.com/DevCenter/PythonEggs#accessing-package-resources

from pkg_resources import resource_string
foo_config = resource_string(__name__, 'foo.conf')

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for plugins to define extra JavaScript and CSS 314506446  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);