issue_comments

Table actions

6 rows where author_association = "OWNER" and issue = 333086005 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Deploy demo of Datasette on every commit that passes tests · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
397908947 https://github.com/simonw/datasette/issues/313#issuecomment-397908947 https://api.github.com/repos/simonw/datasette/issues/313 MDEyOklzc3VlQ29tbWVudDM5NzkwODk0Nw== simonw 9599 2018-06-17T21:51:34Z 2018-06-17T21:51:34Z OWNER

That fixed it! https://958b75c.datasette.io/-/versions

{ "python": { "version": "3.6.5", "full": "3.6.5 (default, Jun 6 2018, 19:19:24) \n[GCC 6.3.0 20170516]" }, "datasette": { "version": "0+unknown", "note": "958b75c69841ef5913da86e0eb2df634a9b95fda" }, "sqlite": { "version": "3.16.2", "fts_versions": [ "FTS5", "FTS4", "FTS3" ], "extensions": { "json1": null } } }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Deploy demo of Datasette on every commit that passes tests 333086005  
397908614 https://github.com/simonw/datasette/issues/313#issuecomment-397908614 https://api.github.com/repos/simonw/datasette/issues/313 MDEyOklzc3VlQ29tbWVudDM5NzkwODYxNA== simonw 9599 2018-06-17T21:44:51Z 2018-06-17T21:45:03Z OWNER

Aha! ```1.03s$ now alias --token=$NOW_TOKEN

Error! Couldn't find a deployment to alias. Please provide one as an argument. The command "now alias --token=$NOW_TOKEN" exited with 1. `` That explains it. I need to set the same alias in my call todatasette publish`.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Deploy demo of Datasette on every commit that passes tests 333086005  
397908185 https://github.com/simonw/datasette/issues/313#issuecomment-397908185 https://api.github.com/repos/simonw/datasette/issues/313 MDEyOklzc3VlQ29tbWVudDM5NzkwODE4NQ== simonw 9599 2018-06-17T21:36:50Z 2018-06-17T21:36:50Z OWNER

The command "datasette publish now fixtures.db -m fixtures.json --token=$NOW_TOKEN --branch=$TRAVIS_COMMIT --version-note=$TRAVIS_COMMIT" exited with 0.

Partial log of the datasette publish now output:

```

Step 5/7 : RUN datasette inspect fixtures.db --inspect-file inspect-data.json ---> Running in d373f330e53e ---> 09bab386aaa3 Removing intermediate container d373f330e53e Step 6/7 : EXPOSE 8001 ---> Running in e0fe37b3061c ---> 47798440e214 Removing intermediate container e0fe37b3061c Step 7/7 : CMD datasette serve --host 0.0.0.0 fixtures.db --cors --port 8001 --inspect-file inspect-data.json --metadata metadata.json --version-note f0c17229b7a7914d3da02e087dfd0e25d8321448 ```

So it looks like --version-note is being correctly set there.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Deploy demo of Datasette on every commit that passes tests 333086005  
397908093 https://github.com/simonw/datasette/issues/313#issuecomment-397908093 https://api.github.com/repos/simonw/datasette/issues/313 MDEyOklzc3VlQ29tbWVudDM5NzkwODA5Mw== simonw 9599 2018-06-17T21:34:52Z 2018-06-17T21:34:52Z OWNER

It looks like all of my test deploys ended up going to the same Zeit deployment ID: https://zeit.co/simonw/datasette-latest/rbmtcedvlj

This is strange... the Dockerfile should be different for each one (due to the differing version-note).

https://github.com/simonw/datasette/commit/db1e6bc182d11f333e6addaa1a6be87625a4e12b#diff-34418c57343344c73271e13b01b7fcd9R255

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Deploy demo of Datasette on every commit that passes tests 333086005  
397907987 https://github.com/simonw/datasette/issues/313#issuecomment-397907987 https://api.github.com/repos/simonw/datasette/issues/313 MDEyOklzc3VlQ29tbWVudDM5NzkwNzk4Nw== simonw 9599 2018-06-17T21:32:52Z 2018-06-17T21:32:52Z OWNER

This very nearly works...

But... https://f0c1722.datasette.io/-/versions isn't showing the correct note: { "datasette": { "version": "0.22.1" } ... There should be a "note" field there with the full commit hash.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Deploy demo of Datasette on every commit that passes tests 333086005  
397900434 https://github.com/simonw/datasette/issues/313#issuecomment-397900434 https://api.github.com/repos/simonw/datasette/issues/313 MDEyOklzc3VlQ29tbWVudDM5NzkwMDQzNA== simonw 9599 2018-06-17T19:23:23Z 2018-06-17T19:23:23Z OWNER

This will require some relatively sophisticated Travis build steps. Useful docs: https://docs.travis-ci.com/user/build-stages/ - useful example: https://docs.travis-ci.com/user/build-stages/deploy-heroku/

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Deploy demo of Datasette on every commit that passes tests 333086005  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);