issue_comments

Table actions

3 rows where author_association = "OWNER", issue = 459509126 and "updated_at" is on date 2019-06-22 sorted by updated_at descending

✖
✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Enforce import sort order with isort · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
504697187 https://github.com/simonw/datasette/issues/516#issuecomment-504697187 https://api.github.com/repos/simonw/datasette/issues/516 MDEyOklzc3VlQ29tbWVudDUwNDY5NzE4Nw== simonw 9599 2019-06-22T20:46:35Z 2019-06-22T20:46:35Z OWNER

I'm going to resist the temptation to do this until I've merged the asgi branch from #272 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  
504696638 https://github.com/simonw/datasette/issues/516#issuecomment-504696638 https://api.github.com/repos/simonw/datasette/issues/516 MDEyOklzc3VlQ29tbWVudDUwNDY5NjYzOA== simonw 9599 2019-06-22T20:37:25Z 2019-06-22T20:38:42Z OWNER

This test added do test_black.py seems to do the trick: python @pytest.mark.parametrize("path", code_root.glob("**/*.py")) def test_isort(path): # Have to capture stdout because isort uses print() directly stdout = sys.stdout sys.stdout = io.StringIO() result = isort.SortImports(path, check=True) assert ( not result.incorrectly_sorted ), "{} has incorrectly sorted imports, fix with 'isort -rc . && black .'" sys.stdout = stdout I'll rename test_black.py to test_lint.py to reflect that it now covers more forms of linting.

Also needed: add move_to_front(items, "test_isort") to conftest.py. And add isort to extras_require in setup.py.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  
504696610 https://github.com/simonw/datasette/issues/516#issuecomment-504696610 https://api.github.com/repos/simonw/datasette/issues/516 MDEyOklzc3VlQ29tbWVudDUwNDY5NjYxMA== simonw 9599 2019-06-22T20:36:57Z 2019-06-22T20:36:57Z OWNER

According to the black documentation the following config file is necessary to avoid isort and black getting into an edit war with each other: [settings] multi_line_output=3 include_trailing_comma=True force_grid_wrap=0 use_parentheses=True line_length=88

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);