issue_comments

Table actions

6 rows where author_association = "OWNER" and issue = 459621683 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Easier way of creating custom row templates · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
507922465 https://github.com/simonw/datasette/issues/521#issuecomment-507922465 https://api.github.com/repos/simonw/datasette/issues/521 MDEyOklzc3VlQ29tbWVudDUwNzkyMjQ2NQ== simonw 9599 2019-07-03T03:23:55Z 2019-07-03T03:23:55Z OWNER

Fixed by #533

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Easier way of creating custom row templates 459621683  
505422550 https://github.com/simonw/datasette/issues/521#issuecomment-505422550 https://api.github.com/repos/simonw/datasette/issues/521 MDEyOklzc3VlQ29tbWVudDUwNTQyMjU1MA== simonw 9599 2019-06-25T12:28:48Z 2019-06-25T12:28:48Z OWNER

Still needed before merge: documentation! I can expand this section: https://datasette.readthedocs.io/en/stable/custom_templates.html#custom-templates

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Easier way of creating custom row templates 459621683  
505421892 https://github.com/simonw/datasette/issues/521#issuecomment-505421892 https://api.github.com/repos/simonw/datasette/issues/521 MDEyOklzc3VlQ29tbWVudDUwNTQyMTg5Mg== simonw 9599 2019-06-25T12:26:54Z 2019-06-25T12:26:54Z OWNER

This is starting to shape up. Example template: ``` {% for row in display_rows %}

{{ row["First_Name"] }} {{ row["Last_Name"] }}

{% if row["Link_to_Photo"] %} {% endif %} {% for cell in row.cells[3:] %} {% if cell.raw and cell.column != "createdTime" %}

{{ cell.column }}: {{ cell.value }}

{% endif %} {% endfor %}

{% endfor %} ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Easier way of creating custom row templates 459621683  
505405030 https://github.com/simonw/datasette/issues/521#issuecomment-505405030 https://api.github.com/repos/simonw/datasette/issues/521 MDEyOklzc3VlQ29tbWVudDUwNTQwNTAzMA== simonw 9599 2019-06-25T11:34:21Z 2019-06-25T11:34:21Z OWNER

Actually I'm OK here - display_columns_and_rows() is already only used by the HTML template rendering path.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Easier way of creating custom row templates 459621683  
505280611 https://github.com/simonw/datasette/issues/521#issuecomment-505280611 https://api.github.com/repos/simonw/datasette/issues/521 MDEyOklzc3VlQ29tbWVudDUwNTI4MDYxMQ== simonw 9599 2019-06-25T04:46:10Z 2019-06-25T04:46:10Z OWNER

Of course I can't do it in this part of he code because it's constructing plain JSON objects here.

I'll need to do it in the section that prepares special objects for the HTML.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Easier way of creating custom row templates 459621683  
505279560 https://github.com/simonw/datasette/issues/521#issuecomment-505279560 https://api.github.com/repos/simonw/datasette/issues/521 MDEyOklzc3VlQ29tbWVudDUwNTI3OTU2MA== simonw 9599 2019-06-25T04:40:16Z 2019-06-25T04:40:38Z OWNER

I think the trick is to redefine what a "cell_row" is. Each row is currently a list of cells:

https://github.com/simonw/datasette/blob/6341f8cbc7833022012804dea120b838ec1f6558/datasette/views/table.py#L159-L163

I can redefine the row (the cells variable in the above example) as a thing-that-iterates-cells (hence behaving like a list) but that also supports __getitem__ access for looking up cell values if you know the name of the column.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Easier way of creating custom row templates 459621683  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);