issue_comments

Table actions

3 rows where author_association = "OWNER" and issue = 463915863 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Mechanism for secrets in plugin configuration · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
508346394 https://github.com/simonw/datasette/issues/538#issuecomment-508346394 https://api.github.com/repos/simonw/datasette/issues/538 MDEyOklzc3VlQ29tbWVudDUwODM0NjM5NA== simonw 9599 2019-07-04T05:43:24Z 2019-07-04T05:43:24Z OWNER

Re-opening this because I messed it up: the secret options are still visible in /-/metadata because I mutate the dictionary in place!

https://github.com/simonw/datasette/blob/a2d45931935f6bb73605a94afedf9e78308c95d6/datasette/app.py#L273-L279

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for secrets in plugin configuration 463915863  
508225524 https://github.com/simonw/datasette/issues/538#issuecomment-508225524 https://api.github.com/repos/simonw/datasette/issues/538 MDEyOklzc3VlQ29tbWVudDUwODIyNTUyNA== simonw 9599 2019-07-03T19:26:32Z 2019-07-03T19:26:32Z OWNER

Another useful option is the ability to load secrets from a file. This allows the file to have permissions set on it to only be read by the Datasette user. It also interacts well with the Kubernetes secrets mechanism, which is file-based. ```json { "plugins": { "datasette-auth-github": { "client_id": "986f5d837b45e32ee6dd", "client_secret": {"$file": "/secrets/github-client-secret"} } } }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for secrets in plugin configuration 463915863  
508224962 https://github.com/simonw/datasette/issues/538#issuecomment-508224962 https://api.github.com/repos/simonw/datasette/issues/538 MDEyOklzc3VlQ29tbWVudDUwODIyNDk2Mg== simonw 9599 2019-07-03T19:24:32Z 2019-07-03T19:24:32Z OWNER

Initial syntax suggestion: json { "title": "datasette-auth-github demo", "plugins": { "datasette-auth-github": { "client_id": "986f5d837b45e32ee6dd", "client_secret": {"$env": "GITHUB_CLIENT_SECRET"} } } }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for secrets in plugin configuration 463915863  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);