issue_comments

Table actions

5 rows where author_association = "OWNER" and issue = 502355384 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Testing utilities should be available to plugins · 5 ✖

author_association 1

  • OWNER · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
592395768 https://github.com/simonw/datasette/issues/580#issuecomment-592395768 https://api.github.com/repos/simonw/datasette/issues/580 MDEyOklzc3VlQ29tbWVudDU5MjM5NTc2OA== simonw 9599 2020-02-28T07:58:46Z 2020-02-28T07:58:46Z OWNER

I don't think this is needed any more - I've found a really nice pattern for testing plugins using httpx instead, e.g. https://github.com/simonw/datasette-mask-columns/blob/f6f08ce21bdfc2731a02c42e1c9e25b4df769292/tests/test_mask_columns.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Testing utilities should be available to plugins 502355384  
561481377 https://github.com/simonw/datasette/issues/580#issuecomment-561481377 https://api.github.com/repos/simonw/datasette/issues/580 MDEyOklzc3VlQ29tbWVudDU2MTQ4MTM3Nw== simonw 9599 2019-12-04T05:18:25Z 2019-12-04T05:18:25Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Testing utilities should be available to plugins 502355384  
554446317 https://github.com/simonw/datasette/issues/580#issuecomment-554446317 https://api.github.com/repos/simonw/datasette/issues/580 MDEyOklzc3VlQ29tbWVudDU1NDQ0NjMxNw== simonw 9599 2019-11-15T17:11:02Z 2019-11-15T17:11:02Z OWNER

Here's where I copied the testing utilities into datasette-template-sql - very slightly modified from the utilities in datasette-atom: https://github.com/simonw/datasette-template-sql/blob/0ef0c7304bb5e658723e229d3ee463b9a76058f9/tests/utils.py

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Testing utilities should be available to plugins 502355384  
554119604 https://github.com/simonw/datasette/issues/580#issuecomment-554119604 https://api.github.com/repos/simonw/datasette/issues/580 MDEyOklzc3VlQ29tbWVudDU1NDExOTYwNA== simonw 9599 2019-11-14T22:51:00Z 2019-11-14T22:51:00Z OWNER

One thing that would be useful is a way of constructing a Datasette() instance (and accompanying TestClient) which is attached to an in-memory database that the test itself can manipulate. This would make it trivial to run tests against hypothetical database tables - those tables could be created using sqlite-utils directly against the in-memory database that's being manipulated by the system-under-test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Testing utilities should be available to plugins 502355384  
554109342 https://github.com/simonw/datasette/issues/580#issuecomment-554109342 https://api.github.com/repos/simonw/datasette/issues/580 MDEyOklzc3VlQ29tbWVudDU1NDEwOTM0Mg== simonw 9599 2019-11-14T22:25:24Z 2019-11-14T22:25:24Z OWNER

I needed this again today for datasette-template-sql.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Testing utilities should be available to plugins 502355384  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);