issue_comments

Table actions

4 rows where author_association = "OWNER" and issue = 625930207 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • register_output_renderer can_render mechanism · 4 ✖

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
634880090 https://github.com/simonw/datasette/issues/770#issuecomment-634880090 https://api.github.com/repos/simonw/datasette/issues/770 MDEyOklzc3VlQ29tbWVudDYzNDg4MDA5MA== simonw 9599 2020-05-27T19:10:57Z 2020-05-28T04:22:47Z OWNER

This can_render callback should take the same arguments as the redesigned render (previously called callback): https://github.com/simonw/datasette/issues/581#issuecomment-634879258

  • datasette - a Datasette instance
  • columns - the list of columns
  • rows - the list of rows (each one a SQLite Row object)
  • sql - the SQL query being executed
  • query_name - the name of the canned query, if this is one
  • database - the database name
  • table - the table or view name
  • request - the request object (to be documented in #706)
  • view_name - the name of the view
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 register_output_renderer can_render mechanism 625930207  
635056520 https://github.com/simonw/datasette/issues/770#issuecomment-635056520 https://api.github.com/repos/simonw/datasette/issues/770 MDEyOklzc3VlQ29tbWVudDYzNTA1NjUyMA== simonw 9599 2020-05-28T02:28:00Z 2020-05-28T02:28:00Z OWNER

This should be optionally awaitable, as in #776

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 register_output_renderer can_render mechanism 625930207  
634980179 https://github.com/simonw/datasette/issues/770#issuecomment-634980179 https://api.github.com/repos/simonw/datasette/issues/770 MDEyOklzc3VlQ29tbWVudDYzNDk4MDE3OQ== simonw 9599 2020-05-27T22:37:19Z 2020-05-27T22:37:19Z OWNER

Can I come up with a better name than should_suggest?

It's a check that sees if the current query is supported by the renderer plugin. Some options:

  • can_render
  • supports_query
  • is_supported

I like can_render.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 register_output_renderer can_render mechanism 625930207  
634880474 https://github.com/simonw/datasette/issues/770#issuecomment-634880474 https://api.github.com/repos/simonw/datasette/issues/770 MDEyOklzc3VlQ29tbWVudDYzNDg4MDQ3NA== simonw 9599 2020-05-27T19:11:39Z 2020-05-27T19:11:39Z OWNER

I'm going to rename callback to render but continue supporting callback until Datasette 1.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 register_output_renderer can_render mechanism 625930207  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);