issue_comments

Table actions

6 rows where author_association = "OWNER" and issue = 634139848 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Mechanism for specifying allow_sql permission in metadata.json · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
640951947 https://github.com/simonw/datasette/issues/813#issuecomment-640951947 https://api.github.com/repos/simonw/datasette/issues/813 MDEyOklzc3VlQ29tbWVudDY0MDk1MTk0Nw== simonw 9599 2020-06-09T00:09:56Z 2020-06-09T00:09:56Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for specifying allow_sql permission in metadata.json 634139848  
640916807 https://github.com/simonw/datasette/issues/813#issuecomment-640916807 https://api.github.com/repos/simonw/datasette/issues/813 MDEyOklzc3VlQ29tbWVudDY0MDkxNjgwNw== simonw 9599 2020-06-08T22:18:09Z 2020-06-08T22:18:09Z OWNER

I could retire the --config allow_sql:0 option entirely, since the new metadata.json mechanism can be used to achieve the exact same thing.

I'm going to do that.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for specifying allow_sql permission in metadata.json 634139848  
640916290 https://github.com/simonw/datasette/issues/813#issuecomment-640916290 https://api.github.com/repos/simonw/datasette/issues/813 MDEyOklzc3VlQ29tbWVudDY0MDkxNjI5MA== simonw 9599 2020-06-08T22:16:39Z 2020-06-08T22:17:32Z OWNER

Naming problem: Datasette already has a config option with this name:

$ datasette serve data.db --config allow_sql:1

https://datasette.readthedocs.io/en/stable/config.html#allow-sql

It's confusing to have two things called allow_sql that do slightly different things.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for specifying allow_sql permission in metadata.json 634139848  
640837908 https://github.com/simonw/datasette/issues/813#issuecomment-640837908 https://api.github.com/repos/simonw/datasette/issues/813 MDEyOklzc3VlQ29tbWVudDY0MDgzNzkwOA== simonw 9599 2020-06-08T19:33:03Z 2020-06-08T19:33:03Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for specifying allow_sql permission in metadata.json 634139848  
640831842 https://github.com/simonw/datasette/issues/813#issuecomment-640831842 https://api.github.com/repos/simonw/datasette/issues/813 MDEyOklzc3VlQ29tbWVudDY0MDgzMTg0Mg== simonw 9599 2020-06-08T19:27:47Z 2020-06-08T19:27:47Z OWNER

This needs to be ready for Datasette 0.44 because without it the "view-table" permission is useless - it will protect the https://latest.datasette.io/fixtures/facetable page but will not prevent users from executing https://latest.datasette.io/fixtures?sql=select+*+from+facetable

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for specifying allow_sql permission in metadata.json 634139848  
640830088 https://github.com/simonw/datasette/issues/813#issuecomment-640830088 https://api.github.com/repos/simonw/datasette/issues/813 MDEyOklzc3VlQ29tbWVudDY0MDgzMDA4OA== simonw 9599 2020-06-08T19:26:15Z 2020-06-08T19:26:15Z OWNER

This needs to affect the ?_where= parameter on table pages as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for specifying allow_sql permission in metadata.json 634139848  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);