issue_comments

Table actions

6 rows where author_association = "OWNER" and issue = 714449879 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Change "--config foo:bar" to "--setting foo bar" · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
733189693 https://github.com/simonw/datasette/issues/992#issuecomment-733189693 https://api.github.com/repos/simonw/datasette/issues/992 MDEyOklzc3VlQ29tbWVudDczMzE4OTY5Mw== simonw 9599 2020-11-24T19:35:38Z 2020-11-24T19:35:38Z OWNER

Part of #1105

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Change "--config foo:bar" to "--setting foo bar" 714449879  
733180289 https://github.com/simonw/datasette/issues/992#issuecomment-733180289 https://api.github.com/repos/simonw/datasette/issues/992 MDEyOklzc3VlQ29tbWVudDczMzE4MDI4OQ== simonw 9599 2020-11-24T19:16:30Z 2020-11-24T19:16:30Z OWNER

Need to figure out the --setting foo bar alternative for this --config foo:bar logic: https://github.com/simonw/datasette/blob/4bac9f18f9d04e5ed10f072502bcc508e365438e/datasette/cli.py#L31-L63

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Change "--config foo:bar" to "--setting foo bar" 714449879  
733176252 https://github.com/simonw/datasette/issues/992#issuecomment-733176252 https://api.github.com/repos/simonw/datasette/issues/992 MDEyOklzc3VlQ29tbWVudDczMzE3NjI1Mg== simonw 9599 2020-11-24T19:07:49Z 2020-11-24T19:07:49Z OWNER

I'm going to keep --config for the moment but show a deprecation warning that it will be gone in Datasette 1.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Change "--config foo:bar" to "--setting foo bar" 714449879  
733175965 https://github.com/simonw/datasette/issues/992#issuecomment-733175965 https://api.github.com/repos/simonw/datasette/issues/992 MDEyOklzc3VlQ29tbWVudDczMzE3NTk2NQ== simonw 9599 2020-11-24T19:07:13Z 2020-11-24T19:07:13Z OWNER

This is blocking progress on other metadata tickets like #860 because I want to split the concept of concrete metadata (source, license, etc) from configuration that currently lives in metadata (default sort order, default facets).

I'm going to solve this next to unblock that stuff.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Change "--config foo:bar" to "--setting foo bar" 714449879  
704013305 https://github.com/simonw/datasette/issues/992#issuecomment-704013305 https://api.github.com/repos/simonw/datasette/issues/992 MDEyOklzc3VlQ29tbWVudDcwNDAxMzMwNQ== simonw 9599 2020-10-06T04:00:00Z 2020-10-06T04:00:00Z OWNER

I can add this well in advance of Datasette 1.0 as an alias to the existing --config option (but taking two arguments instead of one).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Change "--config foo:bar" to "--setting foo bar" 714449879  
703351641 https://github.com/simonw/datasette/issues/992#issuecomment-703351641 https://api.github.com/repos/simonw/datasette/issues/992 MDEyOklzc3VlQ29tbWVudDcwMzM1MTY0MQ== simonw 9599 2020-10-05T01:31:36Z 2020-10-05T01:31:36Z OWNER

If I rename metadata to config in #493 then this should be --setting instead.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Change "--config foo:bar" to "--setting foo bar" 714449879  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);