home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

7 rows where author_association = "OWNER" and issue = 724878151 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 7

issue 1

  • Bring date parsing into Datasette core · 7 ✖

author_association 1

  • OWNER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
712367285 https://github.com/simonw/datasette/issues/1032#issuecomment-712367285 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2NzI4NQ== simonw 9599 2020-10-19T18:39:32Z 2020-10-19T18:39:32Z OWNER

https://github.com/digital-land/brownfield-land-collection/blob/a09ddf9960a6af59e72dc02448f7b645e59bf227/bin/harmonise.py#L217-L247 is a beautiful example of this problem.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  
712365439 https://github.com/simonw/datasette/issues/1032#issuecomment-712365439 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2NTQzOQ== simonw 9599 2020-10-19T18:35:50Z 2020-10-19T18:37:57Z OWNER

Maybe I don't need to add dateutil as a dependency here?

pendulum and arrow both depend on it so it's pretty deeply embedded in the Python date ecosystem. Adding it as a dependency seems reasonable.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  
712365236 https://github.com/simonw/datasette/issues/1032#issuecomment-712365236 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2NTIzNg== simonw 9599 2020-10-19T18:35:25Z 2020-10-19T18:35:25Z OWNER

Since I'm dealing with tables of data I usually have a whole column of examples, so heuristics that check for numbers-greater-than-12 could actually work well for many cases.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  
712364532 https://github.com/simonw/datasette/issues/1032#issuecomment-712364532 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2NDUzMg== simonw 9599 2020-10-19T18:34:10Z 2020-10-19T18:34:10Z OWNER

Lots of great example date data in https://biglocal.datasettes.com/COVID_WARN_Notices

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  
712364317 https://github.com/simonw/datasette/issues/1032#issuecomment-712364317 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2NDMxNw== simonw 9599 2020-10-19T18:33:42Z 2020-10-19T18:33:42Z OWNER

Related challenge: timezones. I think I'll punt on those for the moment and just concentrate on dates, but I should keep them in mind.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  
712363825 https://github.com/simonw/datasette/issues/1032#issuecomment-712363825 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2MzgyNQ== simonw 9599 2020-10-19T18:32:43Z 2020-10-19T18:32:43Z OWNER

Horrible thought: I bet there is data out there that uses more than one date format in the same table! So this needs to be exposed as a visible per-column setting.

Column action menu can help here, although it's not yet the full solution because it isn't yet visible on mobile.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  
712363344 https://github.com/simonw/datasette/issues/1032#issuecomment-712363344 https://api.github.com/repos/simonw/datasette/issues/1032 MDEyOklzc3VlQ29tbWVudDcxMjM2MzM0NA== simonw 9599 2020-10-19T18:31:46Z 2020-10-19T18:31:46Z OWNER

As always with dates, the challenge is America. mm/dd/yy is indistinguishable from the more sensible dd/mm/yy. It's crucially important to visibly tell people which format you assumed, otherwise all kinds of weird invisible bugs can manifest.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Bring date parsing into Datasette core 724878151  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 20.885ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows