issue_comments

Table actions

11 rows where author_association = "OWNER", issue = 742011049 and user = 9599 sorted by updated_at descending

✖
✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date)

user 1

  • simonw · 11 ✖

issue 1

  • .json and .csv exports fail to apply base_url · 11 ✖

author_association 1

  • OWNER · 11 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
758283074 https://github.com/simonw/datasette/issues/1091#issuecomment-758283074 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc1ODI4MzA3NA== simonw 9599 2021-01-11T23:12:46Z 2021-01-11T23:12:46Z OWNER

Fantastic!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
756453945 https://github.com/simonw/datasette/issues/1091#issuecomment-756453945 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc1NjQ1Mzk0NQ== simonw 9599 2021-01-07T23:42:50Z 2021-01-07T23:42:50Z OWNER

@henry501 it looks like you spotted a bug in the documentation - I just addressed that, the fix is now live here: https://docs.datasette.io/en/latest/deploying.html#running-datasette-behind-a-proxy

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 1,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
756453010 https://github.com/simonw/datasette/issues/1091#issuecomment-756453010 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc1NjQ1MzAxMA== simonw 9599 2021-01-07T23:39:58Z 2021-01-07T23:40:25Z OWNER

@tballison I think that's the solution! It looks like you need to use this in your config:

ProxyPass /datasette http://127.0.0.1:8001/datasette

Instead of this:

ProxyPass /datasette http://127.0.0.1:8001/

Give that a go and let me know if it fixes it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
741992106 https://github.com/simonw/datasette/issues/1091#issuecomment-741992106 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MTk5MjEwNg== simonw 9599 2020-12-09T19:19:54Z 2020-12-09T20:27:45Z OWNER

Could you try removing the ProxyPassReverse /datasette http://0.0.0.0:8001 line?

My hunch is that ProxyPassReverse is rewriting some of the links in the HTML (or maybe in the HTTP headers) in a way that breaks things.

Normally you would need ProxyPassReverse to compensate for the underlying application being unable to rewrite its links - but Datasette's base_url setting causes Datasette to rewrite all of the links for you, so ProxyPassReverse should be unneccessary.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
742023541 https://github.com/simonw/datasette/issues/1091#issuecomment-742023541 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDc0MjAyMzU0MQ== simonw 9599 2020-12-09T20:17:54Z 2020-12-09T20:17:54Z OWNER

OK that is really weird. I'll have another go at replicating this locally.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
728262974 https://github.com/simonw/datasette/issues/1091#issuecomment-728262974 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyODI2Mjk3NA== simonw 9599 2020-11-16T19:05:08Z 2020-11-16T19:05:08Z OWNER

I have a hunch that there may be some extra configuration in play here - could Apache itself be rewriting some of the links using mod_proxy_html?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
727233553 https://github.com/simonw/datasette/issues/1091#issuecomment-727233553 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNzIzMzU1Mw== simonw 9599 2020-11-14T16:46:52Z 2020-11-14T16:46:52Z OWNER

@tballison could I see the section of your Apache config that configures the proxying to /datasette/?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726416330 https://github.com/simonw/datasette/issues/1091#issuecomment-726416330 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxNjMzMA== simonw 9599 2020-11-13T00:00:43Z 2020-11-13T00:00:43Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726415991 https://github.com/simonw/datasette/issues/1091#issuecomment-726415991 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxNTk5MQ== simonw 9599 2020-11-12T23:59:34Z 2020-11-12T23:59:34Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726415019 https://github.com/simonw/datasette/issues/1091#issuecomment-726415019 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxNTAxOQ== simonw 9599 2020-11-12T23:56:23Z 2020-11-12T23:56:23Z OWNER

@tballison is there any chance you're running any custom templates in that installation? I'm really confused as to why I can't replicate the bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726413829 https://github.com/simonw/datasette/issues/1091#issuecomment-726413829 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxMzgyOQ== simonw 9599 2020-11-12T23:52:50Z 2020-11-12T23:54:16Z OWNER

Hmm... it's not just the .csv and .json export links - it's the column headings (which can be clicked to change the sort order) as well. Here's an extract of the HTML from that page: ```html

This data as json, CSV ( advanced)

<table class="rows-and-columns"> <thead> <tr> <th class="col-Link" scope="col" data-column="Link" data-column-type="" data-column-not-null="0" data-is-pk="0"> Link </th> <th class="col-rowid" scope="col" data-column="rowid" data-column-type="integer" data-column-not-null="0" data-is-pk="1"> rowid ▼ </th> <th class="col-PARSE_EXCEPTION_ID" scope="col" data-column="PARSE_EXCEPTION_ID" data-column-type="INTEGER" data-column-not-null="0" data-is-pk="0"> PARSE_EXCEPTION_ID </th> <th class="col-PARSE_EXCEPTION_DESCRIPTION" scope="col" data-column="PARSE_EXCEPTION_DESCRIPTION" data-column-type="VARCHAR(128)" data-column-not-null="0" data-is-pk="0"> PARSE_EXCEPTION_DESCRIPTION </th> </tr> </thead> <tbody> <tr> <td class="col-Link type-pk"> 1 </td> <td class="col-rowid type-int">1</td> <td class="col-PARSE_EXCEPTION_ID type-int">0</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">RUNTIME</td> </tr> <tr> <td class="col-Link type-pk"> 2 </td> <td class="col-rowid type-int">2</td> <td class="col-PARSE_EXCEPTION_ID type-int">1</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">ENCRYPTION</td> </tr> <tr> <td class="col-Link type-pk"> 3 </td> <td class="col-rowid type-int">3</td> <td class="col-PARSE_EXCEPTION_ID type-int">2</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">ACCESS_PERMISSION</td> </tr> <tr> <td class="col-Link type-pk"> 4 </td> <td class="col-rowid type-int">4</td> <td class="col-PARSE_EXCEPTION_ID type-int">3</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">UNSUPPORTED_VERSION</td> </tr> </tbody> </table>

Advanced export

JSON shape: default, array, newline-delimited

<form action="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES.csv" method="get">

CSV options: <label> download file </label>

</form>

But here's something _really_ weird - the links to the individual rows DO include the `/datasette/` prefix:html

<td class="col-Link type-pk"> 2 </td>

The navigation bar on that page is correct too:html

home / corpora-metadata

`` I've also been unable to replicate this in my own local environment, runningdatasette fixtures.db --config base_url:/datasette/`.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);