home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

3 rows where author_association = "OWNER" and issue = 837350092 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw 3

issue 1

  • Try implementing SQLite timeouts using .interrupt() instead of using .set_progress_handler() · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
805058241 https://github.com/simonw/datasette/issues/1270#issuecomment-805058241 https://api.github.com/repos/simonw/datasette/issues/1270 MDEyOklzc3VlQ29tbWVudDgwNTA1ODI0MQ== simonw 9599 2021-03-23T16:45:39Z 2021-03-23T16:45:39Z OWNER

I managed to build SpatiaLite such that this isn't necessary any more. I'm still interested in pursuing this further though - it feels like it could be a more robust way of implementing timeouts, but I need to prove to myself that it's better (maybe better performance, or handles more edge-cases?). Not sure how to prove that yet.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Try implementing SQLite timeouts using .interrupt() instead of using .set_progress_handler() 837350092  
804255633 https://github.com/simonw/datasette/issues/1270#issuecomment-804255633 https://api.github.com/repos/simonw/datasette/issues/1270 MDEyOklzc3VlQ29tbWVudDgwNDI1NTYzMw== simonw 9599 2021-03-22T17:32:02Z 2021-03-22T17:32:08Z OWNER

Confirmed that the interrupt() based cancellation mechanism fixes the SpatiaLite issue in #1268!

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Try implementing SQLite timeouts using .interrupt() instead of using .set_progress_handler() 837350092  
803834784 https://github.com/simonw/datasette/issues/1270#issuecomment-803834784 https://api.github.com/repos/simonw/datasette/issues/1270 MDEyOklzc3VlQ29tbWVudDgwMzgzNDc4NA== simonw 9599 2021-03-22T07:31:57Z 2021-03-22T16:22:19Z OWNER

I think the implementation for this goes here: https://github.com/simonw/datasette/blob/6f41c8a2bef309a66588b2875c3e24d26adb4850/datasette/database.py#L146-L157

I figured out a similar pattern in datasette-ripgrep here: https://github.com/simonw/datasette-ripgrep/blob/0.7/datasette_ripgrep/init.py#L63-L71

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Try implementing SQLite timeouts using .interrupt() instead of using .set_progress_handler() 837350092  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 19.37ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows