issue_comments

Table actions

3 rows where author_association = "OWNER", issue = 864979486 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 3 ✖

issue 1

  • Avoid error sorting by relationships if related tables are not allowed · 3 ✖

author_association 1

  • OWNER · 3 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
852710117 https://github.com/simonw/datasette/pull/1306#issuecomment-852710117 https://api.github.com/repos/simonw/datasette/issues/1306 MDEyOklzc3VlQ29tbWVudDg1MjcxMDExNw== simonw 9599 2021-06-02T04:24:33Z 2021-06-02T04:24:33Z OWNER

I have a test - I'll merge this and then add that test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Avoid error sorting by relationships if related tables are not allowed 864979486  
852708574 https://github.com/simonw/datasette/pull/1306#issuecomment-852708574 https://api.github.com/repos/simonw/datasette/issues/1306 MDEyOklzc3VlQ29tbWVudDg1MjcwODU3NA== simonw 9599 2021-06-02T04:20:18Z 2021-06-02T04:20:18Z OWNER

https://github.com/simonw/datasette/blob/115332ce76c0e867d9936406aaf4bcee6b1ef3cb/datasette/views/index.py#L77 helps here - looks like we can pass ?_sort=relationships to trigger the bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Avoid error sorting by relationships if related tables are not allowed 864979486  
852707676 https://github.com/simonw/datasette/pull/1306#issuecomment-852707676 https://api.github.com/repos/simonw/datasette/issues/1306 MDEyOklzc3VlQ29tbWVudDg1MjcwNzY3Ng== simonw 9599 2021-06-02T04:17:41Z 2021-06-02T04:17:41Z OWNER

We need to add a test that illustrates the bug in #1305 so we can prove that this definitely fixes it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Avoid error sorting by relationships if related tables are not allowed 864979486  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);