issue_comments

Table actions

6 rows where author_association = "OWNER", issue_url = "https://api.github.com/repos/simonw/datasette/issues/595" and user = 9599 sorted by updated_at descending

✖
✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: reactions, created_at (date), updated_at (date)

user 1

  • simonw · 6 ✖

author_association 1

  • OWNER · 6 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
552732445 https://github.com/simonw/datasette/pull/595#issuecomment-552732445 https://api.github.com/repos/simonw/datasette/issues/595 MDEyOklzc3VlQ29tbWVudDU1MjczMjQ0NQ== simonw 9599 2019-11-12T04:46:48Z 2019-11-12T04:46:48Z OWNER

Closing this in favour of #627 which upgrades to uvicorn 0.10.4

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941  
552276237 https://github.com/simonw/datasette/pull/595#issuecomment-552276237 https://api.github.com/repos/simonw/datasette/issues/595 MDEyOklzc3VlQ29tbWVudDU1MjI3NjIzNw== simonw 9599 2019-11-11T03:12:56Z 2019-11-11T03:12:56Z OWNER

622

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941  
552275668 https://github.com/simonw/datasette/pull/595#issuecomment-552275668 https://api.github.com/repos/simonw/datasette/issues/595 MDEyOklzc3VlQ29tbWVudDU1MjI3NTY2OA== simonw 9599 2019-11-11T03:09:43Z 2019-11-11T03:09:43Z OWNER

Glitch has been upgraded to Python 3.7. I think I'm happy to drop 3.5 support now - users who want Python 3.5 can get it by installing datasette==0.30.2

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941  
541931047 https://github.com/simonw/datasette/pull/595#issuecomment-541931047 https://api.github.com/repos/simonw/datasette/issues/595 MDEyOklzc3VlQ29tbWVudDU0MTkzMTA0Nw== simonw 9599 2019-10-14T21:25:38Z 2019-10-14T21:25:38Z OWNER

I like the conditional dependency for the moment - maybe until 3.5 becomes officially unsupported.

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941  
541922637 https://github.com/simonw/datasette/pull/595#issuecomment-541922637 https://api.github.com/repos/simonw/datasette/issues/595 MDEyOklzc3VlQ29tbWVudDU0MTkyMjYzNw== simonw 9599 2019-10-14T21:08:19Z 2019-10-14T21:08:19Z OWNER

There more discussion around this on the Glitch forums here: https://support.glitch.com/t/can-you-upgrade-python-to-latest-version/7980

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941  
541494080 https://github.com/simonw/datasette/pull/595#issuecomment-541494080 https://api.github.com/repos/simonw/datasette/issues/595 MDEyOklzc3VlQ29tbWVudDU0MTQ5NDA4MA== simonw 9599 2019-10-14T03:43:11Z 2019-10-14T03:43:11Z OWNER

Ooh this is tricky... https://travis-ci.org/simonw/datasette/jobs/597216285 failed because it looks like websockets-8.0.2 isn't compatible with Python 3.5

This is a problem. I need to keep Datasette working with 3.5 for compatibility with Glitch. But obviously I also want it to work with 3.8.

I wonder if there's a smart solution here. @tomchristie any thoughts?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 bump uvicorn to 0.9.0 to be Python-3.8 friendly 506300941  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);