issue_comments

Table actions

4 rows where author_association = "OWNER" and "updated_at" is on date 2019-11-09 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
552141417 https://github.com/simonw/datasette/issues/617#issuecomment-552141417 https://api.github.com/repos/simonw/datasette/issues/617 MDEyOklzc3VlQ29tbWVudDU1MjE0MTQxNw== simonw 9599 2019-11-09T21:58:40Z 2019-11-09T21:58:40Z OWNER

The function that builds the query could go in a new datasette.utils.sql module.

I can design it to only take simple arguments (the table name, list of columns, list of primary keys and a list of key/value tuples from the query string). This will make it really easy to test (and means it won't need to be async since it won't have to use queries to retrieve those values).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor TableView.data() method 519613116  
552140975 https://github.com/simonw/datasette/issues/283#issuecomment-552140975 https://api.github.com/repos/simonw/datasette/issues/283 MDEyOklzc3VlQ29tbWVudDU1MjE0MDk3NQ== simonw 9599 2019-11-09T21:51:41Z 2019-11-09T21:51:41Z OWNER

It may turn out that we have to recommend NOT exposing a Datasette instance to the public with dozens of database files that has multi-db queries enabled - will need to load test to understand if this recommendation is needed or not.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support cross-database joins 325958506  
552140870 https://github.com/simonw/datasette/issues/283#issuecomment-552140870 https://api.github.com/repos/simonw/datasette/issues/283 MDEyOklzc3VlQ29tbWVudDU1MjE0MDg3MA== simonw 9599 2019-11-09T21:49:51Z 2019-11-09T21:49:51Z OWNER

Better idea: if you run Datasette in cross-database joining mode, all connections start out as memory connections and then have new databases attached to them on-demand.

All table view queries will be automatically rewritten to start SELECT db.table.one, db.table.two FROM db.table ...

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Support cross-database joins 325958506  
552139232 https://github.com/simonw/datasette/issues/618#issuecomment-552139232 https://api.github.com/repos/simonw/datasette/issues/618 MDEyOklzc3VlQ29tbWVudDU1MjEzOTIzMg== simonw 9599 2019-11-09T21:26:11Z 2019-11-09T21:26:11Z OWNER

Easiest solution here would be to append these on to the create table statement that is displayed on the table page.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for seeing indexes on a specific table 520507306  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);