issue_comments

Table actions

12 rows where author_association = "OWNER" and "updated_at" is on date 2020-04-29 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

author_association 1

  • OWNER · 12 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
621045107 https://github.com/simonw/datasette/pull/703#issuecomment-621045107 https://api.github.com/repos/simonw/datasette/issues/703 MDEyOklzc3VlQ29tbWVudDYyMTA0NTEwNw== simonw 9599 2020-04-29T07:49:35Z 2020-04-29T07:49:35Z OWNER

Adding some still-to-do items to a checklist in the description.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 WIP implementation of writable canned queries 585597133  
621041812 https://github.com/simonw/datasette/issues/698#issuecomment-621041812 https://api.github.com/repos/simonw/datasette/issues/698 MDEyOklzc3VlQ29tbWVudDYyMTA0MTgxMg== simonw 9599 2020-04-29T07:42:48Z 2020-04-29T07:42:48Z OWNER

Need to figure out what the .json mode for this looks like - and if there's a .csv mode (I think not).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for a canned query to write to the database 582517965  
621037724 https://github.com/simonw/datasette/issues/698#issuecomment-621037724 https://api.github.com/repos/simonw/datasette/issues/698 MDEyOklzc3VlQ29tbWVudDYyMTAzNzcyNA== simonw 9599 2020-04-29T07:34:02Z 2020-04-29T07:34:02Z OWNER

Concept for displaying a success message:

CSS:

```css .success { padding: 1em; border: 1px solid green; background-color: #c7fbc7; }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for a canned query to write to the database 582517965  
621036032 https://github.com/simonw/datasette/issues/698#issuecomment-621036032 https://api.github.com/repos/simonw/datasette/issues/698 MDEyOklzc3VlQ29tbWVudDYyMTAzNjAzMg== simonw 9599 2020-04-29T07:29:52Z 2020-04-29T07:29:52Z OWNER

What should happen when a query has been successfully executed?

That depends on the query. Some queries may wish to redirect to another page. Other queries might want to show a custom message.

There should at least be a default message saying the query has been executed.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Ability for a canned query to write to the database 582517965  
621027697 https://github.com/simonw/datasette/issues/744#issuecomment-621027697 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMTAyNzY5Nw== simonw 9599 2020-04-29T07:08:09Z 2020-04-29T07:08:09Z OWNER

What operating system are you using? I need to figure out a way to replicate this bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
621027374 https://github.com/simonw/datasette/pull/746#issuecomment-621027374 https://api.github.com/repos/simonw/datasette/issues/746 MDEyOklzc3VlQ29tbWVudDYyMTAyNzM3NA== simonw 9599 2020-04-29T07:07:23Z 2020-04-29T07:07:23Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 shutil.Error, not OSError 608752766  
620972158 https://github.com/simonw/datasette/issues/745#issuecomment-620972158 https://api.github.com/repos/simonw/datasette/issues/745 MDEyOklzc3VlQ29tbWVudDYyMDk3MjE1OA== simonw 9599 2020-04-29T03:35:25Z 2020-04-29T03:35:25Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Extract the hash-URL mechanism out into a plugin 608613033  
620971526 https://github.com/simonw/datasette/issues/744#issuecomment-620971526 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk3MTUyNg== simonw 9599 2020-04-29T03:32:14Z 2020-04-29T03:32:14Z OWNER

@aborruso I think I have a branch with a fix - could you try it out?

Install the new branch like this:

pip install https://github.com/simonw/datasette/archive/issue-744.zip Then try running datasette publish heroku again.

If this fixes your bug I'll merge that pull request!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620970547 https://github.com/simonw/datasette/issues/141#issuecomment-620970547 https://api.github.com/repos/simonw/datasette/issues/141 MDEyOklzc3VlQ29tbWVudDYyMDk3MDU0Nw== simonw 9599 2020-04-29T03:27:37Z 2020-04-29T03:27:54Z OWNER

This bug raised its head again in #744

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 datasette publish can fail if /tmp is on a different device 275814941  
620970475 https://github.com/simonw/datasette/issues/744#issuecomment-620970475 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk3MDQ3NQ== simonw 9599 2020-04-29T03:27:20Z 2020-04-29T03:27:20Z OWNER

This exception handling was introduced in #141

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620970159 https://github.com/simonw/datasette/issues/744#issuecomment-620970159 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk3MDE1OQ== simonw 9599 2020-04-29T03:25:45Z 2020-04-29T03:25:45Z OWNER

https://docs.python.org/3/library/shutil.html#shutil.copytree says that shutil.Error should be raised here, so I think this is a bug in the link_or_copy_directory function.

I don't have an environment that can replicate this bug. @aborruso I'm going to ship a fix in a branch that you can test against.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  
620969639 https://github.com/simonw/datasette/issues/744#issuecomment-620969639 https://api.github.com/repos/simonw/datasette/issues/744 MDEyOklzc3VlQ29tbWVudDYyMDk2OTYzOQ== simonw 9599 2020-04-29T03:23:31Z 2020-04-29T03:23:31Z OWNER

Is it possible that your /tmp directory is on a different volume from the template folder? That could cause a problem with the symlinks.

Here's the code in question:

https://github.com/simonw/datasette/blob/89c4ddd4828623888e91a1d2cb396cba12d4e7b4/datasette/utils/init.py#L595-L609

It looks to me like we were expecting an OSError but in your environment you got a shutil.Error instead. So a fix could be to capture that error as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 link_or_copy_directory() error - Invalid cross-device link 608058890  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);