issue_comments

Table actions

7 rows where author_association = "OWNER" and "updated_at" is on date 2020-12-14 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, reactions, created_at (date), updated_at (date)

user 1

author_association 1

  • OWNER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
744757558 https://github.com/simonw/datasette/issues/1143#issuecomment-744757558 https://api.github.com/repos/simonw/datasette/issues/1143 MDEyOklzc3VlQ29tbWVudDc0NDc1NzU1OA== simonw 9599 2020-12-14T22:42:10Z 2020-12-14T22:42:10Z OWNER

This may involve a breaking change to the CLI settings interface, so I'm adding this to the 1.0 milestone.

 
{
    "total_count": 1,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 1,
    "rocket": 0,
    "eyes": 0
}
 More flexible CORS support in core, to encourage good security practices 764059235  
744756861 https://github.com/simonw/datasette/issues/1143#issuecomment-744756861 https://api.github.com/repos/simonw/datasette/issues/1143 MDEyOklzc3VlQ29tbWVudDc0NDc1Njg2MQ== simonw 9599 2020-12-14T22:40:28Z 2020-12-14T22:40:28Z OWNER

That's a very convincing argument. I'm keen on making sure Datasette is "secure by default" so you're right, encouraging finely grains CORS rules in core rather than leaving that to a plugin sounds like the right call.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 More flexible CORS support in core, to encourage good security practices 764059235  
744576894 https://github.com/simonw/datasette/issues/1142#issuecomment-744576894 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDU3Njg5NA== simonw 9599 2020-12-14T17:03:13Z 2020-12-14T17:03:13Z OWNER

I'm not sure about the radio boxes for JSON, just because you can't right-click on a radio box and copy it to your clipboard like you can with links. Worth trying it out though.

The radio boxes for that CSV option are definitely the right way to go.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744563209 https://github.com/simonw/datasette/issues/1142#issuecomment-744563209 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDU2MzIwOQ== simonw 9599 2020-12-14T16:41:11Z 2020-12-14T16:41:11Z OWNER

To check out and start the server:

/tmp % git clone git@github.com:nitinpaul/datasette
Cloning into 'datasette'...
remote: Enumerating objects: 124, done.
# ...
datasette % python3 -m venv venv
datasette % source venv/bin/activate
(venv) datasette % pip install -e '.[test]'
Obtaining file:///private/tmp/datasette
Collecting asgiref<3.4.0,>=3.2.10
Using cached asgiref-3.3.1-py3-none-any.whl (19 kB)
# ...
(venv) datasette % datasette
INFO:     Started server process [24002]
INFO:     Waiting for application startup.
INFO:     Application startup complete.
INFO:     Uvicorn running on http://127.0.0.1:8001 (Press CTRL+C to quit)

And to run the tests:

(venv) datasette % pytest
======================================================================== test session starts ========================================================================
platform darwin -- Python 3.9.1, pytest-6.1.2, py-1.10.0, pluggy-0.13.1
SQLite: 3.34.0
rootdir: /private/tmp/datasette, configfile: pytest.ini
plugins: asyncio-0.14.0, timeout-1.4.2
collected 841 items

tests/test_package.py ..                                                                                                                                      [  0%]

{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744251252 https://github.com/simonw/datasette/issues/1142#issuecomment-744251252 https://api.github.com/repos/simonw/datasette/issues/1142 MDEyOklzc3VlQ29tbWVudDc0NDI1MTI1Mg== simonw 9599 2020-12-14T07:56:38Z 2020-12-14T07:56:38Z OWNER

That's a really solid design for this! I'd be very happy to review a pull request - you should be able to implement this with just template edits and some CSS changes I think.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "Stream all rows" is not at all obvious 763361458  
744249157 https://github.com/simonw/datasette/issues/1143#issuecomment-744249157 https://api.github.com/repos/simonw/datasette/issues/1143 MDEyOklzc3VlQ29tbWVudDc0NDI0OTE1Nw== simonw 9599 2020-12-14T07:53:15Z 2020-12-14T07:53:15Z OWNER

Does this plugin do everything you need? https://github.com/simonw/datasette-cors

I'm open to arguments as to why this should be in core rather than in a plugin - I'm on the fence about that at the moment.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 More flexible CORS support in core, to encourage good security practices 764059235  
744142692 https://github.com/simonw/datasette/issues/741#issuecomment-744142692 https://api.github.com/repos/simonw/datasette/issues/741 MDEyOklzc3VlQ29tbWVudDc0NDE0MjY5Mg== simonw 9599 2020-12-14T03:28:56Z 2020-12-14T03:28:56Z OWNER

I'm going to try this out on datasette-publish-vercel first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Replace "datasette publish --extra-options" with "--setting" 607223136  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);