issue_comments

Table actions

4 rows where author_association = "OWNER" and "updated_at" is on date 2021-05-17 sorted by updated_at descending

✖
✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

author_association 1

  • OWNER · 4 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
842497125 https://github.com/simonw/datasette/issues/1331#issuecomment-842497125 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NzEyNQ== simonw 9599 2021-05-17T17:20:15Z 2021-05-17T17:20:15Z OWNER

I wonder if there are any new 3.0 features we should be taking advantage of here that would justify pinning to 3.0 minimum?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add support for Jinja2 version 3.0 893537744  
842495346 https://github.com/simonw/datasette/issues/1331#issuecomment-842495346 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NTM0Ng== simonw 9599 2021-05-17T17:17:19Z 2021-05-17T17:17:19Z OWNER

The tests are passing on #1324 so this may not require any code changes at all!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add support for Jinja2 version 3.0 893537744  
842494844 https://github.com/simonw/datasette/pull/1324#issuecomment-842494844 https://api.github.com/repos/simonw/datasette/issues/1324 MDEyOklzc3VlQ29tbWVudDg0MjQ5NDg0NA== simonw 9599 2021-05-17T17:16:36Z 2021-05-17T17:16:36Z OWNER

Refs #1331.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update jinja2 requirement from <2.12.0,>=2.10.3 to >=2.10.3,<3.1.0 890073940  
842494332 https://github.com/simonw/datasette/issues/1331#issuecomment-842494332 https://api.github.com/repos/simonw/datasette/issues/1331 MDEyOklzc3VlQ29tbWVudDg0MjQ5NDMzMg== simonw 9599 2021-05-17T17:15:45Z 2021-05-17T17:16:04Z OWNER

Datasette uses async templates which evidently have been improved in Jinja 2 3.0.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add support for Jinja2 version 3.0 893537744  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);