issue_comments

Renaming sql() to template_sql() in https://github.com/simonw/datasette-template-sql and shipping a 2.0 release of that plugin (it is currently at 1.0.2) would be a sensible short-term fix too.

Relevant code:

https://github.com/simonw/datasette/blob/6a352e99ab988dbf8fd22a100049caa6ad33f1ec/datasette/app.py#L1138-L1149

https://github.com/simonw/datasette/blob/6a352e99ab988dbf8fd22a100049caa6ad33f1ec/datasette/app.py#L1193-L1195

This is tricky. datasette-template-sql registers a custom sql() function, but @cldellow spotted a situation where this would interfere with an existing {{ sql }} variable in a template context!

https://github.com/simonw/datasette-template-sql/blob/70483fd94bb0349761830e37c9ab928e8966841a/datasette_template_sql/init.py

```python @hookimpl def extra_template_vars(datasette): async def execute_sql(sql, args=None, database=None): db = datasette.get_database(database) return (await db.execute(sql, args)).rows

return {"sql": execute_sql}

```

A few options: - Ensure that the explicit template context overrides anything that plugins might do - so in this case the sql(...) function would not be available on that page. This would break people who have custom templates that use that function though. - Encourage naming conventions where functions and variables from plugins are less likely to interfere with existing functionality. - Completely change how templates work, so you never have a variable called {{ sql }} - it is always accessed via some parent object instead, such as {{ page.sql }}.

That last option actually fits quite well with my efforts to unify template rendering with JSON (and JSON extras) so it might be the best way to address this.

Fixed: - https://docs.datasette.io/en/latest/installation.html#using-pip - https://docs.datasette.io/en/stable/installation.html#using-pip - https://docs.datasette.io/en/0.64.1/installation.html#using-pip

I'm going to leave the bad link in the old versions, because I can't figure out a way to update them using ReadTheDocs - shipping 0.64.1 will at least mean that both /latest/ and /stable/ have a good link.

That change is now live on https://docs.datasette.io/en/latest/installation.html#using-pip

I may need to ship a new stable dot-release to update the /en/stable/ page though.

Next challenge: how to best deploy this.

Ideally I'd like to fix all of the older versions of the docs too - pages like https://docs.datasette.io/en/0.59.4/installation.html#using-pip

Not sure if ReadTheDocs has a mechanism for that.

Datasette(path) should either work or it should return an easily debugged error message.