issue_comments

Table actions

7 rows where author_association = "OWNER" and "updated_at" is on date 2023-02-06 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

author_association 1

  • OWNER · 7 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1419953256 https://github.com/simonw/datasette/issues/2019#issuecomment-1419953256 https://api.github.com/repos/simonw/datasette/issues/2019 IC_kwDOBm6k_c5UosRo simonw 9599 2023-02-06T23:42:56Z 2023-02-06T23:43:10Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor out the keyset pagination code 1573424830  
1419928455 https://github.com/simonw/datasette/issues/2019#issuecomment-1419928455 https://api.github.com/repos/simonw/datasette/issues/2019 IC_kwDOBm6k_c5UomOH simonw 9599 2023-02-06T23:21:50Z 2023-02-06T23:21:50Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor out the keyset pagination code 1573424830  
1419921228 https://github.com/simonw/datasette/issues/2019#issuecomment-1419921228 https://api.github.com/repos/simonw/datasette/issues/2019 IC_kwDOBm6k_c5UokdM simonw 9599 2023-02-06T23:14:15Z 2023-02-06T23:14:15Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor out the keyset pagination code 1573424830  
1419917661 https://github.com/simonw/datasette/issues/2019#issuecomment-1419917661 https://api.github.com/repos/simonw/datasette/issues/2019 IC_kwDOBm6k_c5Uojld simonw 9599 2023-02-06T23:10:51Z 2023-02-06T23:10:51Z OWNER

I should turn sort and sort_desc into an object representing the sort order earlier in the code.

I should also create something that bundles together pks and use_rowid and maybe is_view as well.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor out the keyset pagination code 1573424830  
1419916684 https://github.com/simonw/datasette/issues/2019#issuecomment-1419916684 https://api.github.com/repos/simonw/datasette/issues/2019 IC_kwDOBm6k_c5UojWM simonw 9599 2023-02-06T23:09:51Z 2023-02-06T23:10:13Z OWNER

The inputs and outputs for this are pretty complex.

Inputs:

  • ?_next= from the query string
  • is_view - is this for a table or view? If it's a view it uses offset/limit pagination - which could actually work for arbitrary queries too. Also views could have keyset pagination if they are known to be sorted by a particular column.
  • sort and sort_desc reflecting the current sort order
  • use_rowid for if the table is a rowid table with no primary key of its own
  • pks - the primary keys for the table
  • params - the current set of parameters, I think used just to count their length so new params can be added as p5 etc without collisions. This could be handled with a s0, s1 etc naming convention instead.

Outputs:

  • where_clauses - a list of where clauses to add to the query
  • params - additional parameters to use with the query due to the new where clauses
  • order_by - the order by clause
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Refactor out the keyset pagination code 1573424830  
1399343659 https://github.com/simonw/datasette/pull/1999#issuecomment-1399343659 https://api.github.com/repos/simonw/datasette/issues/1999 IC_kwDOBm6k_c5TaEor simonw 9599 2023-01-21T22:19:20Z 2023-02-06T23:02:12Z OWNER

HTML mode needs a list of renderers so it can show links to .geojson etc - can do that as a hidden extra (maybe called renderers), repeating this code:

https://github.com/simonw/datasette/blob/e4ebef082de90db4e1b8527abc0d582b7ae0bc9d/datasette/views/base.py#L477-L497

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 ?_extra= support (draft) 1551694938  
1418288327 https://github.com/simonw/datasette/issues/262#issuecomment-1418288327 https://api.github.com/repos/simonw/datasette/issues/262 IC_kwDOBm6k_c5UiVzH simonw 9599 2023-02-05T22:57:58Z 2023-02-06T23:01:15Z OWNER

I think that does make sense: ?_extra=table perhaps, which would add {"table": "..."}.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add ?_extra= mechanism for requesting extra properties in JSON 323658641  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);