issue_comments

This is implemented now: - https://docs.datasette.io/en/stable/internals.html#await-ensure-permissions-actor-permissions

This is going to happen in this tool instead: - https://github.com/simonw/dclient

Documentation preview: https://github.com/simonw/datasette/blob/6321c9c055a640ed6ea98e231dc5813dcde1f773/docs/plugins.rst#controlling-which-plugins-are-loaded

Here's the reason for that name disparity:

https://github.com/simonw/datasette/blob/30b28c8367a9c6870386ea10a202705b40862457/datasette/plugins.py#L54-L65

Note how the distinfo.project_name name is used when available. That seems to work for regularly installed plugins but not for plugins loaded via DATASETTE_LOAD_PLUGINS.

And that's looking things up in plugin_to_distinfo which is populated here:

https://github.com/simonw/datasette/blob/30b28c8367a9c6870386ea10a202705b40862457/datasette/plugins.py#L37

The load_setuptools_entrypoints() function in Pluggy does this:

python for ep in dist.entry_points: if ( ep.group != group or (name is not None and ep.name != name) # already registered or self.get_plugin(ep.name) or self.is_blocked(ep.name) ): continue plugin = ep.load() self.register(plugin, name=ep.name)

Slight weirdness: I noticed that the output from the datasette plugins command looks like this for plugins loaded with the new environment variable: json { "name": "datasette_pretty_json", "static": false, "templates": false, "version": null, "hooks": [ "render_cell" ] }, That should ideally be datasette-pretty-json, not datasette_pretty_json.

Testing this is going to be a bit of a pain.

I think I'll add a whole separate test block to CI which installs a couple of plugins and then exercises this feature using datasette plugins.

I'll use datasette-init and datasette-json-html just because they are small and simple.

Figured this out so far with the help of GPT-4: https://chat.openai.com/share/0e785865-621b-4fb3-ba05-7449e57c8496

Now this works: bash DATASETTE_LOAD_PLUGINS=datasette-write-ui datasette plugins json [ { "name": "datasette_write_ui", "static": true, "templates": true, "version": null, "hooks": [ "extra_template_vars", "register_routes" ] } ] Or multiple plugins: bash DATASETTE_LOAD_PLUGINS=datasette-write-ui,datasette-pretty-json datasette plugins Outputs: json [ { "name": "datasette_pretty_json", "static": false, "templates": false, "version": null, "hooks": [ "render_cell" ] }, { "name": "datasette_write_ui", "static": true, "templates": true, "version": null, "hooks": [ "extra_template_vars", "register_routes" ] } ]