home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

16 rows where "created_at" is on date 2017-11-11 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

issue 11

  • Default HTML/CSS needs to look reasonable and be responsive 3
  • Command line tool for uploading one or more DBs to Now 3
  • Create neat example database 2
  • Datasette Plugins 1
  • Implement command-line tool interface 1
  • Unit tests against application itself 1
  • Implement a better database index page 1
  • Views should not attempt to link to records / use rowids 1
  • datasette publish hyper 1
  • Rethink how metadata is generated and stored 1
  • Review design of JSON output 1

user 1

  • simonw 16

author_association 1

  • OWNER 16
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
343699115 https://github.com/simonw/datasette/issues/53#issuecomment-343699115 https://api.github.com/repos/simonw/datasette/issues/53 MDEyOklzc3VlQ29tbWVudDM0MzY5OTExNQ== simonw 9599 2017-11-11T22:41:38Z 2017-11-11T22:41:38Z OWNER

This needs to incorporate a sensible way of presenting custom SQL query results too. And let's get a textarea in there for executing SQL while we're at it.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Implement a better database index page 273054652  
343698214 https://github.com/simonw/datasette/issues/50#issuecomment-343698214 https://api.github.com/repos/simonw/datasette/issues/50 MDEyOklzc3VlQ29tbWVudDM0MzY5ODIxNA== simonw 9599 2017-11-11T22:23:21Z 2017-11-11T22:23:21Z OWNER

I'm closing #50 - more tests will be added in the future, but the framework is neatly in place for them now.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Unit tests against application itself 272694136  
343697291 https://github.com/simonw/datasette/issues/63#issuecomment-343697291 https://api.github.com/repos/simonw/datasette/issues/63 MDEyOklzc3VlQ29tbWVudDM0MzY5NzI5MQ== simonw 9599 2017-11-11T22:05:06Z 2017-11-11T22:11:49Z OWNER

I'm going to bundle sql and sql_params together into a query nested object like this:

{
    "query": {
        "sql": "select ...",
        "params": {
            "p0": "blah"
        }
    }
}
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Review design of JSON output 273174447  
343691342 https://github.com/simonw/datasette/issues/16#issuecomment-343691342 https://api.github.com/repos/simonw/datasette/issues/16 MDEyOklzc3VlQ29tbWVudDM0MzY5MTM0Mg== simonw 9599 2017-11-11T20:19:07Z 2017-11-11T20:19:07Z OWNER

Closing this, opening a fresh ticket for the navigation stuff.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Default HTML/CSS needs to look reasonable and be responsive 267726219  
343690060 https://github.com/simonw/datasette/issues/47#issuecomment-343690060 https://api.github.com/repos/simonw/datasette/issues/47 MDEyOklzc3VlQ29tbWVudDM0MzY5MDA2MA== simonw 9599 2017-11-11T19:56:08Z 2017-11-11T19:56:08Z OWNER
"parlgov-development.db": {
    "url": "http://www.parlgov.org/"
},
"nhsadmin.sqlite": {
    "url": "https://github.com/psychemedia/openHealthDataDoodles"
}
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Create neat example database 271831408  
343683566 https://github.com/simonw/datasette/issues/60#issuecomment-343683566 https://api.github.com/repos/simonw/datasette/issues/60 MDEyOklzc3VlQ29tbWVudDM0MzY4MzU2Ng== simonw 9599 2017-11-11T18:12:24Z 2017-11-11T18:12:24Z OWNER

I’m going to solve this by making it an optional argument you can pass to the serve command. Then the Dockerfile can still build and use it but it won’t interfere with tests or dev.

If argument is not passed, we will calculate hashes on startup and calculate table row counts on demand.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Rethink how metadata is generated and stored 273163905  
343676574 https://github.com/simonw/datasette/issues/59#issuecomment-343676574 https://api.github.com/repos/simonw/datasette/issues/59 MDEyOklzc3VlQ29tbWVudDM0MzY3NjU3NA== simonw 9599 2017-11-11T16:29:48Z 2017-11-11T16:29:48Z OWNER

See also #14

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
datasette publish hyper 273157085  
343675165 https://github.com/simonw/datasette/issues/14#issuecomment-343675165 https://api.github.com/repos/simonw/datasette/issues/14 MDEyOklzc3VlQ29tbWVudDM0MzY3NTE2NQ== simonw 9599 2017-11-11T16:07:10Z 2017-11-11T16:07:10Z OWNER

The plugin system can also allow alternative providers for the publish command - e.g. maybe hook up hyper.sh as an option for publishing containers.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Datasette Plugins 267707940  
343647300 https://github.com/simonw/datasette/issues/16#issuecomment-343647300 https://api.github.com/repos/simonw/datasette/issues/16 MDEyOklzc3VlQ29tbWVudDM0MzY0NzMwMA== simonw 9599 2017-11-11T07:41:19Z 2017-11-11T07:53:09Z OWNER

Still needed:

  • [ ] A link to the homepage from some kind of navigation bar in the header
  • [ ] link to github.com/simonw/datasette in the footer
  • [ ] Slightly better titles (maybe ditch the visited link colours for titles only? should keep those for primary key links)
  • [ ] Links to the .json and .jsono versions of every view
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Default HTML/CSS needs to look reasonable and be responsive 267726219  
343647102 https://github.com/simonw/datasette/issues/47#issuecomment-343647102 https://api.github.com/repos/simonw/datasette/issues/47 MDEyOklzc3VlQ29tbWVudDM0MzY0NzEwMg== simonw 9599 2017-11-11T07:36:00Z 2017-11-11T07:36:00Z OWNER

http://2016.padjo.org/tutorials/data-primer-census-acs1-demographics/ has a sqlite database: http://2016.padjo.org/files/data/starterpack/census-acs-1year/acs-1-year-2015.sqlite

I tested this by deploying it here: https://datasette-fewuggrvwr.now.sh/

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Create neat example database 271831408  
343646740 https://github.com/simonw/datasette/issues/40#issuecomment-343646740 https://api.github.com/repos/simonw/datasette/issues/40 MDEyOklzc3VlQ29tbWVudDM0MzY0Njc0MA== simonw 9599 2017-11-11T07:27:33Z 2017-11-11T07:27:33Z OWNER

I'm happy with this now that I've implemented the publish command in #26

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Implement command-line tool interface 268470572  
343645327 https://github.com/simonw/datasette/issues/26#issuecomment-343645327 https://api.github.com/repos/simonw/datasette/issues/26 MDEyOklzc3VlQ29tbWVudDM0MzY0NTMyNw== simonw 9599 2017-11-11T06:51:16Z 2017-11-11T06:51:16Z OWNER

I can create the temporary directory like so:

import tempfile
t = tempfile.TemporaryDirectory()
t
<TemporaryDirectory '/var/folders/w9/0xm39tk94ng9h52g06z4b54c0000gp/T/tmpkym70wlp'>
t.name
'/var/folders/w9/0xm39tk94ng9h52g06z4b54c0000gp/T/tmpkym70wlp'

And then to delete it all:

t.cleanup()
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Command line tool for uploading one or more DBs to Now 267861210  
343645249 https://github.com/simonw/datasette/issues/26#issuecomment-343645249 https://api.github.com/repos/simonw/datasette/issues/26 MDEyOklzc3VlQ29tbWVudDM0MzY0NTI0OQ== simonw 9599 2017-11-11T06:48:59Z 2017-11-11T06:48:59Z OWNER

Doing this works:

import os
os.link('/tmp/databases/northwind.db', '/tmp/tmp-blah/northwind.db')

That creates a link in tmp-blah - and then when I delete that entire directory like so:

import shutil
shutil.rmtree('/tmp/tmp-blah')

The original database is not deleted, just the link.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Command line tool for uploading one or more DBs to Now 267861210  
343644976 https://github.com/simonw/datasette/issues/26#issuecomment-343644976 https://api.github.com/repos/simonw/datasette/issues/26 MDEyOklzc3VlQ29tbWVudDM0MzY0NDk3Ng== simonw 9599 2017-11-11T06:42:23Z 2017-11-11T06:42:23Z OWNER

Simplest version of this:

  1. Create a temporary directory
  2. Write a Dockerfile into it that pulls an image and pip installs datasette
  3. Add symlinks to the DBs they listed (so we don't have to copy them)
  4. Shell out to "now"
  5. Done!
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Command line tool for uploading one or more DBs to Now 267861210  
343644891 https://github.com/simonw/datasette/issues/54#issuecomment-343644891 https://api.github.com/repos/simonw/datasette/issues/54 MDEyOklzc3VlQ29tbWVudDM0MzY0NDg5MQ== simonw 9599 2017-11-11T06:39:54Z 2017-11-11T06:39:54Z OWNER

I can detect something is a view like this:

SELECT name from sqlite_master WHERE type ='view';
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Views should not attempt to link to records / use rowids 273121803  
343643332 https://github.com/simonw/datasette/issues/16#issuecomment-343643332 https://api.github.com/repos/simonw/datasette/issues/16 MDEyOklzc3VlQ29tbWVudDM0MzY0MzMzMg== simonw 9599 2017-11-11T06:00:04Z 2017-11-11T06:00:04Z OWNER

Here's what a table looks like now at a smaller screen size:

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Default HTML/CSS needs to look reasonable and be responsive 267726219  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 460.789ms · About: github-to-sqlite
  • Sort ascending
  • Sort descending
  • Facet by this
  • Hide this column
  • Show all columns
  • Show not-blank rows