issue_comments
28 rows where "created_at" is on date 2018-04-16 and "updated_at" is on date 2018-04-16 sorted by updated_at descending
This data as json, CSV (advanced)
Suggested facets: issue_url, created_at (date), updated_at (date)
id | html_url | issue_url | node_id | user | created_at | updated_at ▲ | author_association | body | reactions | issue | performed_via_github_app |
---|---|---|---|---|---|---|---|---|---|---|---|
381786522 | https://github.com/simonw/datasette/issues/216#issuecomment-381786522 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTc4NjUyMg== | simonw 9599 | 2018-04-16T23:58:45Z | 2018-04-16T23:59:13Z | OWNER | Weird... tests are failing in Travis, despite passing on my local machine. https://travis-ci.org/simonw/datasette/builds/367423706 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381777108 | https://github.com/simonw/datasette/issues/220#issuecomment-381777108 | https://api.github.com/repos/simonw/datasette/issues/220 | MDEyOklzc3VlQ29tbWVudDM4MTc3NzEwOA== | simonw 9599 | 2018-04-16T23:04:04Z | 2018-04-16T23:04:04Z | OWNER | This could also help workaround the current predicament that a single plugin can only define one prepare_connection hook. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Investigate syntactic sugar for plugins 314847571 | |
381763651 | https://github.com/simonw/datasette/issues/203#issuecomment-381763651 | https://api.github.com/repos/simonw/datasette/issues/203 | MDEyOklzc3VlQ29tbWVudDM4MTc2MzY1MQ== | russss 45057 | 2018-04-16T21:59:17Z | 2018-04-16T21:59:17Z | CONTRIBUTOR | Ah, I had no idea you could bind python functions into sqlite! I think the primary purpose of this issue has been served now - I'm going to close this and create a new issue for the only bit of this that hasn't been touched yet, which is (optionally) exposing units in the JSON API. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Support for units 313837303 | |
381738137 | https://github.com/simonw/datasette/pull/209#issuecomment-381738137 | https://api.github.com/repos/simonw/datasette/issues/209 | MDEyOklzc3VlQ29tbWVudDM4MTczODEzNw== | russss 45057 | 2018-04-16T20:27:43Z | 2018-04-16T20:27:43Z | CONTRIBUTOR | Tests now fixed, honest. The failing test on Travis looks like an intermittent sqlite failure which should resolve itself on a retry... |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Don't duplicate simple primary keys in the link column 314455877 | |
381649437 | https://github.com/simonw/datasette/issues/216#issuecomment-381649437 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0OTQzNw== | simonw 9599 | 2018-04-16T15:39:21Z | 2018-04-16T15:39:21Z | OWNER | Here's where that SQL gets constructed at the moment: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381649140 | https://github.com/simonw/datasette/issues/216#issuecomment-381649140 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0OTE0MA== | simonw 9599 | 2018-04-16T15:38:29Z | 2018-04-16T15:38:29Z | OWNER | But what would that SQL look like for |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381648053 | https://github.com/simonw/datasette/issues/216#issuecomment-381648053 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0ODA1Mw== | simonw 9599 | 2018-04-16T15:35:17Z | 2018-04-16T15:35:17Z | OWNER | I think the correct SQL is this: https://datasette-issue-189-demo-3.now.sh/salaries-7859114-7859114?sql=select+rowid%2C+*+from+%5B2017+Maryland+state+salaries%5D%0D%0Awhere+%28middle_initial+is+not+null+or+%28middle_initial+is+null+and+rowid+%3E+%3Ap0%29%29%0D%0Aorder+by+middle_initial+limit+101&p0=391
Though this will also need to be taken into account for #198 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381645973 | https://github.com/simonw/datasette/issues/216#issuecomment-381645973 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0NTk3Mw== | simonw 9599 | 2018-04-16T15:29:11Z | 2018-04-16T15:29:11Z | OWNER | I could use ```
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381645274 | https://github.com/simonw/datasette/issues/216#issuecomment-381645274 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0NTI3NA== | simonw 9599 | 2018-04-16T15:27:16Z | 2018-04-16T15:27:16Z | OWNER | { "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | ||
381644355 | https://github.com/simonw/datasette/issues/216#issuecomment-381644355 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0NDM1NQ== | simonw 9599 | 2018-04-16T15:24:38Z | 2018-04-16T15:24:38Z | OWNER | So there are two tricky problems to solve here:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381643173 | https://github.com/simonw/datasette/issues/216#issuecomment-381643173 | https://api.github.com/repos/simonw/datasette/issues/216 | MDEyOklzc3VlQ29tbWVudDM4MTY0MzE3Mw== | simonw 9599 | 2018-04-16T15:21:17Z | 2018-04-16T15:21:17Z | OWNER | Yikes, definitely a bug. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Bug: Sort by column with NULL in next_page URL 314665147 | |
381621338 | https://github.com/simonw/datasette/issues/14#issuecomment-381621338 | https://api.github.com/repos/simonw/datasette/issues/14 | MDEyOklzc3VlQ29tbWVudDM4MTYyMTMzOA== | simonw 9599 | 2018-04-16T14:36:27Z | 2018-04-16T14:36:27Z | OWNER | Annoyingly, the following only results in the last of the two ``` from datasette import hookimpl import pint import random ureg = pint.UnitRegistry() @hookimpl def prepare_connection(conn): def convert_units(amount, from_, to_): "select convert_units(100, 'm', 'ft');" return (amount * ureg(from_)).to(to_).to_tuple()[0] conn.create_function('convert_units', 3, convert_units) @hookimpl def prepare_connection(conn): conn.create_function('random_integer', 2, random.randint) ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Plugins 267707940 | |
381612585 | https://github.com/simonw/datasette/issues/214#issuecomment-381612585 | https://api.github.com/repos/simonw/datasette/issues/214 | MDEyOklzc3VlQ29tbWVudDM4MTYxMjU4NQ== | simonw 9599 | 2018-04-16T14:10:16Z | 2018-04-16T14:10:16Z | OWNER |
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability for plugins to define extra JavaScript and CSS 314506446 | |
381611738 | https://github.com/simonw/datasette/issues/14#issuecomment-381611738 | https://api.github.com/repos/simonw/datasette/issues/14 | MDEyOklzc3VlQ29tbWVudDM4MTYxMTczOA== | simonw 9599 | 2018-04-16T14:07:30Z | 2018-04-16T14:07:30Z | OWNER | I should check if it's possible to have two template registration function plugins in a single plugin module. If it isn't maybe I should use class plugins instead of module plugins. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Plugins 267707940 | |
381602005 | https://github.com/simonw/datasette/issues/191#issuecomment-381602005 | https://api.github.com/repos/simonw/datasette/issues/191 | MDEyOklzc3VlQ29tbWVudDM4MTYwMjAwNQ== | coleifer 119974 | 2018-04-16T13:37:32Z | 2018-04-16T13:37:32Z | NONE | I don't think it should be too difficult... you can look at what @ghaering did with pysqlite (and similarly what I copied for pysqlite3). You would theoretically take an amalgamation build of Sqlite (all code in a single .c and .h file). The |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Figure out how to bundle a more up-to-date SQLite 310533258 | |
381491707 | https://github.com/simonw/datasette/issues/214#issuecomment-381491707 | https://api.github.com/repos/simonw/datasette/issues/214 | MDEyOklzc3VlQ29tbWVudDM4MTQ5MTcwNw== | simonw 9599 | 2018-04-16T06:21:23Z | 2018-04-16T06:21:23Z | OWNER | This looks like a good example: https://github.com/funkey/nyroglancer/commit/d4438ab42171360b2b8e9020f672846dd70c8d80 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability for plugins to define extra JavaScript and CSS 314506446 | |
381490361 | https://github.com/simonw/datasette/issues/214#issuecomment-381490361 | https://api.github.com/repos/simonw/datasette/issues/214 | MDEyOklzc3VlQ29tbWVudDM4MTQ5MDM2MQ== | simonw 9599 | 2018-04-16T06:13:02Z | 2018-04-16T06:13:02Z | OWNER | Packaging JS and CSS in a pip installable wheel is fiddly but possible. http://peak.telecommunity.com/DevCenter/PythonEggs#accessing-package-resources
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Ability for plugins to define extra JavaScript and CSS 314506446 | |
381488049 | https://github.com/simonw/datasette/issues/191#issuecomment-381488049 | https://api.github.com/repos/simonw/datasette/issues/191 | MDEyOklzc3VlQ29tbWVudDM4MTQ4ODA0OQ== | simonw 9599 | 2018-04-16T05:58:15Z | 2018-04-16T05:58:15Z | OWNER | I think this is pretty hard. @coleifer has done some work in this direction, including https://github.com/coleifer/pysqlite3 which ports the standalone pysqlite module to Python 3. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Figure out how to bundle a more up-to-date SQLite 310533258 | |
381483301 | https://github.com/simonw/datasette/pull/209#issuecomment-381483301 | https://api.github.com/repos/simonw/datasette/issues/209 | MDEyOklzc3VlQ29tbWVudDM4MTQ4MzMwMQ== | simonw 9599 | 2018-04-16T05:25:08Z | 2018-04-16T05:25:08Z | OWNER | I think this is a good improvement. If you fix the tests I'll merge it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Don't duplicate simple primary keys in the link column 314455877 | |
381482407 | https://github.com/simonw/datasette/issues/211#issuecomment-381482407 | https://api.github.com/repos/simonw/datasette/issues/211 | MDEyOklzc3VlQ29tbWVudDM4MTQ4MjQwNw== | simonw 9599 | 2018-04-16T05:18:29Z | 2018-04-16T05:18:29Z | OWNER | Here's the result of running this:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load plugins from a `--plugins-dir=plugins/` directory 314471743 | |
381481990 | https://github.com/simonw/datasette/issues/211#issuecomment-381481990 | https://api.github.com/repos/simonw/datasette/issues/211 | MDEyOklzc3VlQ29tbWVudDM4MTQ4MTk5MA== | simonw 9599 | 2018-04-16T05:14:57Z | 2018-04-16T05:14:57Z | OWNER | Added unit tests in 33c6bcadb962457be6b0c7f369826b404e2bcef5 |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load plugins from a `--plugins-dir=plugins/` directory 314471743 | |
381478253 | https://github.com/simonw/datasette/issues/211#issuecomment-381478253 | https://api.github.com/repos/simonw/datasette/issues/211 | MDEyOklzc3VlQ29tbWVudDM4MTQ3ODI1Mw== | simonw 9599 | 2018-04-16T04:42:02Z | 2018-04-16T04:42:02Z | OWNER | This worked as well:
|
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load plugins from a `--plugins-dir=plugins/` directory 314471743 | |
381478217 | https://github.com/simonw/datasette/issues/211#issuecomment-381478217 | https://api.github.com/repos/simonw/datasette/issues/211 | MDEyOklzc3VlQ29tbWVudDM4MTQ3ODIxNw== | simonw 9599 | 2018-04-16T04:41:38Z | 2018-04-16T04:41:38Z | OWNER | Here's the result of running:
Where ureg = pint.UnitRegistry() @hookimpl def prepare_connection(conn): def convert_units(amount, from_, to_): "select convert_units(100, 'm', 'ft');" return (amount * ureg(from_)).to(to_).to_tuple()[0] conn.create_function('convert_units', 3, convert_units) ``` |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load plugins from a `--plugins-dir=plugins/` directory 314471743 | |
381462005 | https://github.com/simonw/datasette/issues/211#issuecomment-381462005 | https://api.github.com/repos/simonw/datasette/issues/211 | MDEyOklzc3VlQ29tbWVudDM4MTQ2MjAwNQ== | simonw 9599 | 2018-04-16T02:23:07Z | 2018-04-16T02:23:07Z | OWNER | This needs unit tests. I also need to manually test the |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load plugins from a `--plugins-dir=plugins/` directory 314471743 | |
381456434 | https://github.com/simonw/datasette/issues/211#issuecomment-381456434 | https://api.github.com/repos/simonw/datasette/issues/211 | MDEyOklzc3VlQ29tbWVudDM4MTQ1NjQzNA== | simonw 9599 | 2018-04-16T01:36:16Z | 2018-04-16T01:37:44Z | OWNER | The easiest way to implement this in Python 2 would be
Implementing it this way would force this kind of plugin to be self-contained in a single file. I think that's OK: if you want a more complex plugin you can use the standard pluggy-powered setuptools mechanism to build it. |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Load plugins from a `--plugins-dir=plugins/` directory 314471743 | |
381455054 | https://github.com/simonw/datasette/issues/139#issuecomment-381455054 | https://api.github.com/repos/simonw/datasette/issues/139 | MDEyOklzc3VlQ29tbWVudDM4MTQ1NTA1NA== | simonw 9599 | 2018-04-16T01:24:13Z | 2018-04-16T01:24:13Z | OWNER | I think Vega-Lite is the way to go here: https://vega.github.io/vega-lite/ I've been playing around with it and Datasette with some really positive initial results: |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Build a visualization plugin for Vega 275493851 | |
381450591 | https://github.com/simonw/datasette/issues/14#issuecomment-381450591 | https://api.github.com/repos/simonw/datasette/issues/14 | MDEyOklzc3VlQ29tbWVudDM4MTQ1MDU5MQ== | simonw 9599 | 2018-04-16T00:30:22Z | 2018-04-16T00:34:42Z | OWNER | Slight code design problem... when I tried installing my branch in a fresh virtual environment I got this error, because
Looks like I've run into point 6 on https://packaging.python.org/guides/single-sourcing-package-version/ : |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Plugins 267707940 | |
381450394 | https://github.com/simonw/datasette/issues/14#issuecomment-381450394 | https://api.github.com/repos/simonw/datasette/issues/14 | MDEyOklzc3VlQ29tbWVudDM4MTQ1MDM5NA== | simonw 9599 | 2018-04-16T00:27:23Z | 2018-04-16T00:27:23Z | OWNER | I created https://github.com/simonw/datasette-plugin-demos which is now published to PyPI and can be installed with |
{ "total_count": 0, "+1": 0, "-1": 0, "laugh": 0, "hooray": 0, "confused": 0, "heart": 0, "rocket": 0, "eyes": 0 } |
Datasette Plugins 267707940 |
Advanced export
JSON shape: default, array, newline-delimited, object
CREATE TABLE [issue_comments] ( [html_url] TEXT, [issue_url] TEXT, [id] INTEGER PRIMARY KEY, [node_id] TEXT, [user] INTEGER REFERENCES [users]([id]), [created_at] TEXT, [updated_at] TEXT, [author_association] TEXT, [body] TEXT, [reactions] TEXT, [issue] INTEGER REFERENCES [issues]([id]) , [performed_via_github_app] TEXT); CREATE INDEX [idx_issue_comments_issue] ON [issue_comments] ([issue]); CREATE INDEX [idx_issue_comments_user] ON [issue_comments] ([user]);
issue 9