home / github

Menu
  • Search all tables
  • GraphQL API

issue_comments

Table actions
  • GraphQL API for issue_comments

11 rows where "created_at" is on date 2018-05-29 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

issue 6

  • Figure out how to bundle a more up-to-date SQLite 3
  • Handle spatialite geometry columns better 3
  • Per-database and per-table /-/ URL namespace 2
  • Link to JSON for the list of tables 1
  • Add links to example Datasette instances to appropiate places in docs 1
  • URLify URLs in results from custom SQL statements / views 1

user 4

  • simonw 7
  • yschimke 2
  • russss 1
  • coleifer 1

author_association 3

  • OWNER 7
  • NONE 3
  • CONTRIBUTOR 1
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
392969173 https://github.com/simonw/datasette/issues/276#issuecomment-392969173 https://api.github.com/repos/simonw/datasette/issues/276 MDEyOklzc3VlQ29tbWVudDM5Mjk2OTE3Mw== simonw 9599 2018-05-29T22:32:08Z 2018-05-29T22:32:08Z OWNER

The more time I spend with SpatiaLite the more convinced I am that this should be default behavior. There's nothing useful about the binary Geometry representation - it's not even valid WKB. I'm on board with WKT as the default display in HTML and GeoJSON as the default for .json

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Handle spatialite geometry columns better 324835838  
392918311 https://github.com/simonw/datasette/issues/296#issuecomment-392918311 https://api.github.com/repos/simonw/datasette/issues/296 MDEyOklzc3VlQ29tbWVudDM5MjkxODMxMQ== simonw 9599 2018-05-29T19:44:33Z 2018-05-29T19:44:33Z OWNER

Should the tablename ones also work for views and canned queries? Probably not.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Per-database and per-table /-/ URL namespace 327395270  
392840811 https://github.com/simonw/datasette/issues/296#issuecomment-392840811 https://api.github.com/repos/simonw/datasette/issues/296 MDEyOklzc3VlQ29tbWVudDM5Mjg0MDgxMQ== simonw 9599 2018-05-29T16:26:27Z 2018-05-29T19:43:23Z OWNER

Since #275 will allow configs to be overridden at the table and database level it also makes sense to expose a completely evaluated list of configs at:

  • /dbname/-/config
  • /dbname/tablename/-/config

Similar to https://fivethirtyeight.datasettes.com/-/config

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Per-database and per-table /-/ URL namespace 327395270  
392917380 https://github.com/simonw/datasette/issues/298#issuecomment-392917380 https://api.github.com/repos/simonw/datasette/issues/298 MDEyOklzc3VlQ29tbWVudDM5MjkxNzM4MA== simonw 9599 2018-05-29T19:41:59Z 2018-05-29T19:41:59Z OWNER

Creating URLs using concatenation as seen in ('https://twitter.com/' || user) as user_url is likely to have all sorts of useful applications for ad-hoc analysis.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
URLify URLs in results from custom SQL statements / views 327459829  
392895733 https://github.com/simonw/datasette/issues/97#issuecomment-392895733 https://api.github.com/repos/simonw/datasette/issues/97 MDEyOklzc3VlQ29tbWVudDM5Mjg5NTczMw== yschimke 231923 2018-05-29T18:51:35Z 2018-05-29T18:51:35Z NONE

Do you have an existing example with views?

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Link to JSON for the list of tables  274022950  
392890045 https://github.com/simonw/datasette/issues/265#issuecomment-392890045 https://api.github.com/repos/simonw/datasette/issues/265 MDEyOklzc3VlQ29tbWVudDM5Mjg5MDA0NQ== yschimke 231923 2018-05-29T18:37:49Z 2018-05-29T18:37:49Z NONE

Just about to ask for this! Move this page https://github.com/simonw/datasette/wiki/Datasettes

into a datasette, with some concept of versioning as well.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Add links to example Datasette instances to appropiate places in docs 323677499  
392831543 https://github.com/simonw/datasette/issues/191#issuecomment-392831543 https://api.github.com/repos/simonw/datasette/issues/191 MDEyOklzc3VlQ29tbWVudDM5MjgzMTU0Mw== simonw 9599 2018-05-29T15:58:33Z 2018-05-29T15:58:33Z OWNER

I ran an informal survey on twitter and most people were on 3.21 - https://twitter.com/simonw/status/1001487546289815553

Maybe this is from upgrading to the latest OS X release.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to bundle a more up-to-date SQLite 310533258  
392828475 https://github.com/simonw/datasette/issues/191#issuecomment-392828475 https://api.github.com/repos/simonw/datasette/issues/191 MDEyOklzc3VlQ29tbWVudDM5MjgyODQ3NQ== coleifer 119974 2018-05-29T15:50:18Z 2018-05-29T15:50:18Z NONE

Python standard-library SQLite dynamically links against the system sqlite3. So presumably you installed a more up-to-date sqlite3 somewhere on your LD_LIBRARY_PATH.

To compile a statically-linked pysqlite you need to include an amalgamation in the project root when building the extension. Read the relevant setup.py.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to bundle a more up-to-date SQLite 310533258  
392825746 https://github.com/simonw/datasette/issues/276#issuecomment-392825746 https://api.github.com/repos/simonw/datasette/issues/276 MDEyOklzc3VlQ29tbWVudDM5MjgyNTc0Ng== russss 45057 2018-05-29T15:42:53Z 2018-05-29T15:42:53Z CONTRIBUTOR

I haven't had time to look further into this, but if doing this as a plugin results in useful hooks then I think we should do it that way. We could always require the plugin as a standard dependency.

I think this is going to result in quite a bit of refactoring anyway so it's a good time to add hooks regardless.

On the other hand, if we have to add lots of specialist hooks for it then maybe it's worth integrating into the core.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Handle spatialite geometry columns better 324835838  
392822050 https://github.com/simonw/datasette/issues/191#issuecomment-392822050 https://api.github.com/repos/simonw/datasette/issues/191 MDEyOklzc3VlQ29tbWVudDM5MjgyMjA1MA== simonw 9599 2018-05-29T15:33:25Z 2018-05-29T15:33:25Z OWNER

I don't know how it happened, but I've somehow got myself into a state where my local SQLite for Python 3 on OS X is 3.23.1:

``` ~ $ python3 Python 3.6.5 (default, Mar 30 2018, 06:41:53) [GCC 4.2.1 Compatible Apple LLVM 9.0.0 (clang-900.0.39.2)] on darwin Type "help", "copyright", "credits" or "license" for more information.

import sqlite3 sqlite3.connect(':memory:').execute('select sqlite_version()').fetchall() [('3.23.1',)]

``` Maybe I did something in homebrew that changed this? I'd love to understand what exactly I did to get to this state.

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Figure out how to bundle a more up-to-date SQLite 310533258  
392815673 https://github.com/simonw/datasette/issues/276#issuecomment-392815673 https://api.github.com/repos/simonw/datasette/issues/276 MDEyOklzc3VlQ29tbWVudDM5MjgxNTY3Mw== simonw 9599 2018-05-29T15:17:04Z 2018-05-29T15:17:04Z OWNER

I'm coming round to the idea that this should be baked into Datasette core - see above referenced issues for some of the explorations I've been doing around this area.

Datasette should absolutely work without SpatiaLite, but it's such a huge bonus part of the SQLite ecosystem that I'm happy to ship features that take advantage of it without being relegated to plugins.

I'm also becoming aware that there aren't really that many other interesting loadable extensions for SQLite. If SpatiaLite was one of dozens I'd feel that a rule that "anything dependent on an extension lives in a plugin" would make sense, but as it stands I think 99% of the time the only loadable extensions people will be using will be SpatiaLite and json1 (and json1 is available in the amalgamation anyway).

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
Handle spatialite geometry columns better 324835838  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options:

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);
Powered by Datasette · Queries took 465.29ms · About: github-to-sqlite