issue_comments

Table actions

7 rows where "created_at" is on date 2019-10-18 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 2

author_association 2

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
544014518 https://github.com/simonw/datasette/pull/601#issuecomment-544014518 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0NDAxNDUxOA== simonw 9599 2019-10-18T23:57:44Z 2019-10-18T23:57:44Z OWNER

That's a good idea. It could even be smart about it and only show the "Format SQL" button on that page of the output of the function would differ from what's there already.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
544008944 https://github.com/simonw/datasette/pull/601#issuecomment-544008944 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0NDAwODk0NA== rixx 2657547 2019-10-18T23:40:48Z 2019-10-18T23:40:48Z CONTRIBUTOR

The only negative impact that comes to mind is that now you have no way to get the read-only query to be formatted nicely, I think, so maybe a second PR adding the formatting functionality even to the read-only page would be good?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
544008463 https://github.com/simonw/datasette/pull/601#issuecomment-544008463 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0NDAwODQ2Mw== rixx 2657547 2019-10-18T23:39:21Z 2019-10-18T23:39:21Z CONTRIBUTOR

That looks right, and I completely agree with the intent.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
543991999 https://github.com/simonw/datasette/issues/598#issuecomment-543991999 https://api.github.com/repos/simonw/datasette/issues/598 MDEyOklzc3VlQ29tbWVudDU0Mzk5MTk5OQ== simonw 9599 2019-10-18T22:52:21Z 2019-10-18T22:52:21Z OWNER

This is fixed in master - should be releasing the fix as Datasette 0.30 in the next few days. #584 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Character encoding bug with CSV export 508100844  
543986312 https://github.com/simonw/datasette/pull/601#issuecomment-543986312 https://api.github.com/repos/simonw/datasette/issues/601 MDEyOklzc3VlQ29tbWVudDU0Mzk4NjMxMg== simonw 9599 2019-10-18T22:38:00Z 2019-10-18T22:38:00Z OWNER

@rixx does this look like the right way to do #600 to you?

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Don't auto-format SQL on page load 509340359  
543900283 https://github.com/simonw/datasette/issues/597#issuecomment-543900283 https://api.github.com/repos/simonw/datasette/issues/597 MDEyOklzc3VlQ29tbWVudDU0MzkwMDI4Mw== simonw 9599 2019-10-18T19:25:57Z 2019-10-18T19:27:06Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 If you have databases called foo.db and foo-bar.db you cannot visit /foo-bar 508070977  
543427426 https://github.com/simonw/datasette/issues/584#issuecomment-543427426 https://api.github.com/repos/simonw/datasette/issues/584 MDEyOklzc3VlQ29tbWVudDU0MzQyNzQyNg== simonw 9599 2019-10-18T00:39:15Z 2019-10-18T00:39:15Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Codec error in some CSV exports 503190241  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);