issue_comments

I think ALL explicit options should over-ride options that were detected in the directory structure. This means my current implementation isn't quite right - using a class method makes it hard to merge the details with the explicit options passed to the CLI function.

Work now happening in the pull request: https://github.com/simonw/datasette/issues/739

https://www.niche-museums.com/about now uses this mechanism. It used to be an empty about.db database but you can see from https://www.niche-museums.com/-/databases that it's now using the new mechanism.

I've shipped #648 now, so no reason not to go with the static/ folder as the thing that gets detected and mounted as /static.

https://github.com/simonw/datasette/blob/304e7b1d9fd904ae1c35600bc03662eb90eeeae0/datasette/app.py#L781-L789

request is an optional argument here:

https://github.com/simonw/datasette/blob/304e7b1d9fd904ae1c35600bc03662eb90eeeae0/datasette/app.py#L556-L558

Documentation: https://datasette.readthedocs.io/en/latest/custom_templates.html#custom-pages

Just needs documentation now.

I'm going with custom_header(name, value), custom_status(numeric_code), custom_redirect("URL").

Design challenge: the function that can be called in the custom template to return a custom status code and/or headers.

Proposed design: {{ custom_headers({"x-foo": "bar"}) }} {{ custom_status_code(404) }} Or should I combine them into one function? {{ custom_headers({"x-foo": "bar"}, status=404) }} A common use-case here would be a redirect. How should that look? {{ custom_redirect("/foo") }} - defaults to 301 {{ custom_redirect("/foo", status=302) }} Maybe avoid dictionary syntax entirely: {{ custom_header("x-foo", "bar") }}

Stretch goal: it would be neat if these pages could return custom HTTP headers (eg content-type) and maybe even status codes (eg for redirects) somehow.

I think I could do that with a custom template function - if that function is called during the render then we follow those instructions instead of returning the rendered HTML. https://github.com/simonw/datasette/issues/648#issuecomment-619591380

Stretch goal: it would be neat if these pages could return custom HTTP headers (eg content-type) and maybe even status codes (eg for redirects) somehow.

I think I could do that with a custom template function - if that function is called during the render then we follow those instructions instead of returning the rendered HTML.

as a complementary remark: the versioning of datasette dependancies will become a problem when the new pip "dependancy resolver" will be activated. for now, it's just warnings via pip checks, later it will be a "no":

datasette 0.40 has requirement aiofiles~=0.4.0, but you have aiofiles 0.5.0. datasette 0.40 has requirement Jinja2~=2.10.3, but you have jinja2 2.11.2.