issue_comments

Table actions

11 rows where "created_at" is on date 2020-06-02 and "updated_at" is on date 2020-06-02 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

user 1

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
637875307 https://github.com/simonw/datasette/pull/703#issuecomment-637875307 https://api.github.com/repos/simonw/datasette/issues/703 MDEyOklzc3VlQ29tbWVudDYzNzg3NTMwNw== simonw 9599 2020-06-02T23:57:35Z 2020-06-02T23:57:35Z OWNER

This pull request got too messy. I'm going to abandon this and start a new one.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 WIP implementation of writable canned queries 585597133  
637843494 https://github.com/simonw/datasette/issues/790#issuecomment-637843494 https://api.github.com/repos/simonw/datasette/issues/790 MDEyOklzc3VlQ29tbWVudDYzNzg0MzQ5NA== simonw 9599 2020-06-02T22:35:22Z 2020-06-02T22:35:22Z OWNER

Message CSS is now demonstrated on https://latest.datasette.io/-/patterns

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "flash messages" mechanism 628499086  
637841942 https://github.com/simonw/datasette/issues/794#issuecomment-637841942 https://api.github.com/repos/simonw/datasette/issues/794 MDEyOklzc3VlQ29tbWVudDYzNzg0MTk0Mg== simonw 9599 2020-06-02T22:30:17Z 2020-06-02T22:30:17Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show hooks implemented by each plugin on /-/plugins 629535669  
637832651 https://github.com/simonw/datasette/issues/794#issuecomment-637832651 https://api.github.com/repos/simonw/datasette/issues/794 MDEyOklzc3VlQ29tbWVudDYzNzgzMjY1MQ== simonw 9599 2020-06-02T22:10:34Z 2020-06-02T22:10:34Z OWNER

Demo: https://latest.datasette.io/-/plugins?all=1

json [ { "name": "datasette.facets", "static": false, "templates": false, "version": null, "hooks": [ "register_facet_classes" ] }, { "name": "datasette.publish.cloudrun", "static": false, "templates": false, "version": null, "hooks": [ "publish_subcommand" ] }, { "name": "datasette.actor_auth_cookie", "static": false, "templates": false, "version": null, "hooks": [ "actor_from_request" ] }, { "name": "datasette.default_permissions", "static": false, "templates": false, "version": null, "hooks": [ "permission_allowed" ] }, { "name": "datasette.sql_functions", "static": false, "templates": false, "version": null, "hooks": [ "prepare_connection" ] }, { "name": "datasette.publish.heroku", "static": false, "templates": false, "version": null, "hooks": [ "publish_subcommand" ] } ]

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Show hooks implemented by each plugin on /-/plugins 629535669  
637819025 https://github.com/simonw/datasette/issues/699#issuecomment-637819025 https://api.github.com/repos/simonw/datasette/issues/699 MDEyOklzc3VlQ29tbWVudDYzNzgxOTAyNQ== simonw 9599 2020-06-02T21:34:31Z 2020-06-02T21:34:31Z OWNER

I can close this issue once I've expanded out this page of documentation https://datasette.readthedocs.io/en/latest/authentication.html - and published at least one plugin and/or feature that takes advantage of this new mechanism.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Authentication (and permissions) as a core concept 582526961  
637813993 https://github.com/simonw/datasette/issues/793#issuecomment-637813993 https://api.github.com/repos/simonw/datasette/issues/793 MDEyOklzc3VlQ29tbWVudDYzNzgxMzk5Mw== simonw 9599 2020-06-02T21:22:50Z 2020-06-02T21:22:50Z OWNER

This is a minor security issue with master at the moment, but I'll resolve this before I ship the next release.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 CSRF protection for /-/messages tool and writable canned queries 629524205  
637813616 https://github.com/simonw/datasette/issues/790#issuecomment-637813616 https://api.github.com/repos/simonw/datasette/issues/790 MDEyOklzc3VlQ29tbWVudDYzNzgxMzYxNg== simonw 9599 2020-06-02T21:22:02Z 2020-06-02T21:22:02Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "flash messages" mechanism 628499086  
637793590 https://github.com/simonw/datasette/issues/790#issuecomment-637793590 https://api.github.com/repos/simonw/datasette/issues/790 MDEyOklzc3VlQ29tbWVudDYzNzc5MzU5MA== simonw 9599 2020-06-02T20:40:02Z 2020-06-02T20:40:02Z OWNER

From https://github.com/simonw/datasette/issues/698#issuecomment-621037724

Concept for displaying a success message:

CSS:

```css .success { padding: 1em; border: 1px solid green; background-color: #c7fbc7; }

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "flash messages" mechanism 628499086  
637790860 https://github.com/simonw/datasette/issues/790#issuecomment-637790860 https://api.github.com/repos/simonw/datasette/issues/790 MDEyOklzc3VlQ29tbWVudDYzNzc5MDg2MA== simonw 9599 2020-06-02T20:34:15Z 2020-06-02T20:34:15Z OWNER

The /-/messages debug tool will need CSRF protection or people will be able to add messages using a hidden form on another website.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "flash messages" mechanism 628499086  
637708090 https://github.com/simonw/datasette/issues/790#issuecomment-637708090 https://api.github.com/repos/simonw/datasette/issues/790 MDEyOklzc3VlQ29tbWVudDYzNzcwODA5MA== simonw 9599 2020-06-02T17:52:30Z 2020-06-02T17:52:30Z OWNER

I need to make sure that any time cookies are set there's no cache-control header (or it is set to private).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "flash messages" mechanism 628499086  
637699337 https://github.com/simonw/datasette/issues/790#issuecomment-637699337 https://api.github.com/repos/simonw/datasette/issues/790 MDEyOklzc3VlQ29tbWVudDYzNzY5OTMzNw== simonw 9599 2020-06-02T17:34:47Z 2020-06-02T17:34:47Z OWNER

I'm going to use a output renderer plugin to test this, since then my unit tests can run against custom code that both sets and displays messages.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 "flash messages" mechanism 628499086  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);