issue_comments

Table actions

3 rows where "created_at" is on date 2020-06-10 and issue = 634917088 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Example permissions plugin · 3 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
642231871 https://github.com/simonw/datasette/issues/818#issuecomment-642231871 https://api.github.com/repos/simonw/datasette/issues/818 MDEyOklzc3VlQ29tbWVudDY0MjIzMTg3MQ== simonw 9599 2020-06-10T20:11:50Z 2020-06-10T20:11:50Z OWNER

datasette-permissions-sql yaml plugins: datasette-permissions-sql: view-instance: |- select count(*) from users where admin = 1 and id = :id

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Example permissions plugin 634917088  
642230499 https://github.com/simonw/datasette/issues/818#issuecomment-642230499 https://api.github.com/repos/simonw/datasette/issues/818 MDEyOklzc3VlQ29tbWVudDY0MjIzMDQ5OQ== simonw 9599 2020-06-10T20:08:46Z 2020-06-10T20:09:26Z OWNER

What's a simple but useful plugin I could release that exercises this hook?

Ideally one which executes permission checks against the database somehow.

I could do a simplest-possible implementation of the idea in #801 (allow-by-query).

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Example permissions plugin 634917088  
642229899 https://github.com/simonw/datasette/issues/818#issuecomment-642229899 https://api.github.com/repos/simonw/datasette/issues/818 MDEyOklzc3VlQ29tbWVudDY0MjIyOTg5OQ== simonw 9599 2020-06-10T20:07:36Z 2020-06-10T20:07:36Z OWNER

New policy in 9f236c4 dictates that this should be in Milestone 0.44 after all:

  • New plugin hooks should only be shipped if accompanied by a separate release of a non-demo plugin that uses them.
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Example permissions plugin 634917088  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);