issue_comments

Table actions

4 rows where "created_at" is on date 2020-06-11 and issue = 637253789 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • /-/metadata and so on should respect view-instance permission · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
642958225 https://github.com/simonw/datasette/issues/833#issuecomment-642958225 https://api.github.com/repos/simonw/datasette/issues/833 MDEyOklzc3VlQ29tbWVudDY0Mjk1ODIyNQ== simonw 9599 2020-06-11T22:15:32Z 2020-06-11T22:15:32Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 /-/metadata and so on should respect view-instance permission 637253789  
642905424 https://github.com/simonw/datasette/issues/833#issuecomment-642905424 https://api.github.com/repos/simonw/datasette/issues/833 MDEyOklzc3VlQ29tbWVudDY0MjkwNTQyNA== simonw 9599 2020-06-11T20:16:41Z 2020-06-11T20:16:41Z OWNER

I'll add a new test in test_permissions.py which locks down an instance and then loops through paths as the anonymous user making sure they aren't accessible.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 /-/metadata and so on should respect view-instance permission 637253789  
642902208 https://github.com/simonw/datasette/issues/833#issuecomment-642902208 https://api.github.com/repos/simonw/datasette/issues/833 MDEyOklzc3VlQ29tbWVudDY0MjkwMjIwOA== simonw 9599 2020-06-11T20:08:57Z 2020-06-11T20:08:57Z OWNER

I'm tempted to add a view-instance check before routing any URLs, but that wouldn't be compatible with the idea in #832 that having view-table should be enough to view a table even if you don't pass view-instance.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 /-/metadata and so on should respect view-instance permission 637253789  
642874724 https://github.com/simonw/datasette/issues/833#issuecomment-642874724 https://api.github.com/repos/simonw/datasette/issues/833 MDEyOklzc3VlQ29tbWVudDY0Mjg3NDcyNA== simonw 9599 2020-06-11T19:07:49Z 2020-06-11T19:07:49Z OWNER

A live demo running the datasette-auth-github plugin will help demonstrate this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 /-/metadata and so on should respect view-instance permission 637253789  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);