issue_comments

Table actions

6 rows where "created_at" is on date 2020-08-16, issue = 679779797 and "updated_at" is on date 2020-08-16 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • extra_ plugin hooks should take the same arguments · 6 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
674548163 https://github.com/simonw/datasette/issues/939#issuecomment-674548163 https://api.github.com/repos/simonw/datasette/issues/939 MDEyOklzc3VlQ29tbWVudDY3NDU0ODE2Mw== simonw 9599 2020-08-16T16:34:30Z 2020-08-16T16:34:30Z OWNER

Docs also need to note that request may be None for all of these hooks.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 extra_ plugin hooks should take the same arguments 679779797  
674547811 https://github.com/simonw/datasette/issues/939#issuecomment-674547811 https://api.github.com/repos/simonw/datasette/issues/939 MDEyOklzc3VlQ29tbWVudDY3NDU0NzgxMQ== simonw 9599 2020-08-16T16:31:20Z 2020-08-16T16:31:20Z OWNER

And the docs need to be updated too.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 extra_ plugin hooks should take the same arguments 679779797  
674547788 https://github.com/simonw/datasette/issues/939#issuecomment-674547788 https://api.github.com/repos/simonw/datasette/issues/939 MDEyOklzc3VlQ29tbWVudDY3NDU0Nzc4OA== simonw 9599 2020-08-16T16:31:08Z 2020-08-16T16:31:08Z OWNER

Also: they should all be able to return async def inner functions. At the moment only extra_template_vars supports that pattern.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 extra_ plugin hooks should take the same arguments 679779797  
674545058 https://github.com/simonw/datasette/issues/939#issuecomment-674545058 https://api.github.com/repos/simonw/datasette/issues/939 MDEyOklzc3VlQ29tbWVudDY3NDU0NTA1OA== simonw 9599 2020-08-16T16:07:20Z 2020-08-16T16:07:20Z OWNER

I'm going to implement this first as a single commit, then implement columns from #938 as a separate change.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 extra_ plugin hooks should take the same arguments 679779797  
674544973 https://github.com/simonw/datasette/issues/939#issuecomment-674544973 https://api.github.com/repos/simonw/datasette/issues/939 MDEyOklzc3VlQ29tbWVudDY3NDU0NDk3Mw== simonw 9599 2020-08-16T16:06:34Z 2020-08-16T16:06:34Z OWNER

They should also be next to each other in the documentation - right now they're a bit scattered in terms of page order:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 extra_ plugin hooks should take the same arguments 679779797  
674544875 https://github.com/simonw/datasette/issues/939#issuecomment-674544875 https://api.github.com/repos/simonw/datasette/issues/939 MDEyOklzc3VlQ29tbWVudDY3NDU0NDg3NQ== simonw 9599 2020-08-16T16:05:36Z 2020-08-16T16:05:36Z OWNER

They should all take:

template, database, table, view_name, request, datasette, columns

columns is new, see #938.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 extra_ plugin hooks should take the same arguments 679779797  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);