issue_comments

Table actions

8 rows where "created_at" is on date 2020-10-12 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, created_at (date), updated_at (date)

author_association 4

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
706834800 https://github.com/dogsheep/evernote-to-sqlite/issues/5#issuecomment-706834800 https://api.github.com/repos/dogsheep/evernote-to-sqlite/issues/5 MDEyOklzc3VlQ29tbWVudDcwNjgzNDgwMA== simonw 9599 2020-10-12T03:24:57Z 2020-10-16T20:16:28Z MEMBER

Here's my first attempt at a plugin for this: ```python from datasette import hookimpl import jinja2

START = "<en-note" END = "</en-note>" TEMPLATE = """

{}
""".strip()

EN_MEDIA_SCRIPT = """ Array.from(document.querySelectorAll('en-media')).forEach(el => { let hash = el.getAttribute('hash'); let type = el.getAttribute('type'); let path = /evernote/resources_data/${hash}.json?_shape=array; fetch(path).then(r => r.json()).then(rows => { let b64 = rows[0].data.encoded; let data = data:${type};base64,${b64}; el.innerHTML = <img style="max-width: 300px" src="${data}">; }); }); """

@hookimpl def render_cell(value, table): if not table: # Don't render content from arbitrary SQL queries, could be XSS hole return if not value or not isinstance(value, str): return value = value.strip() if value.startswith(START) and value.endswith(END): trimmed = value[len(START) : -len(END)] trimmed = trimmed.split(">", 1)[1] # Replace those horrible double newlines trimmed = trimmed.replace("


", "
") return jinja2.Markup(TEMPLATE.format(trimmed))

@hookimpl def extra_body_script(): return EN_MEDIA_SCRIPT ``` It works!

It does however demonstrate that Evernote's "clip this webpage" feature means there is a LOT of weird HTML that can get into a note. It looks like they've filtered out the scripts but I wouldn't bet on it - they certainly don't filter out many of the inline styles. So running Bleach is almost certainly a good idea.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Figure out how to display images from <en-media> tags inline in Datasette 718938889  
707332912 https://github.com/dogsheep/swarm-to-sqlite/issues/8#issuecomment-707332912 https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/8 MDEyOklzc3VlQ29tbWVudDcwNzMzMjkxMg== simonw 9599 2020-10-12T20:35:06Z 2020-10-12T20:35:06Z MEMBER

Shipped a fix for this in swarm-to-sqlite 0.3.2.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Error thrown: table photos has no column named hasSticker 648245071  
707326192 https://github.com/dogsheep/swarm-to-sqlite/pull/10#issuecomment-707326192 https://api.github.com/repos/dogsheep/swarm-to-sqlite/issues/10 MDEyOklzc3VlQ29tbWVudDcwNzMyNjE5Mg== mattiaborsoi 29426418 2020-10-12T20:20:02Z 2020-10-12T20:20:02Z CONTRIBUTOR

This closes issue #8 

{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update utils.py to fix sqlite3.OperationalError 719637258  
707125737 https://github.com/simonw/datasette/pull/1018#issuecomment-707125737 https://api.github.com/repos/simonw/datasette/issues/1018 MDEyOklzc3VlQ29tbWVudDcwNzEyNTczNw== codecov[bot] 22429695 2020-10-12T13:38:35Z 2020-10-12T13:38:35Z NONE

Codecov Report

Merging #1018 into main will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1018 +/-

======================================= Coverage 84.56% 84.56%
======================================= Files 28 28
Lines 3882 3882
======================================= Hits 3283 3283
Misses 599 599
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acf07a6...4b021be. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update asgiref requirement from ~=3.2.10 to >=3.2.10,<3.4.0 719382156  
707123799 https://github.com/simonw/datasette/pull/1017#issuecomment-707123799 https://api.github.com/repos/simonw/datasette/issues/1017 MDEyOklzc3VlQ29tbWVudDcwNzEyMzc5OQ== codecov[bot] 22429695 2020-10-12T13:34:51Z 2020-10-12T13:34:51Z NONE

Codecov Report

Merging #1017 into main will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1017 +/-

======================================= Coverage 84.56% 84.56%
======================================= Files 28 28
Lines 3882 3882
======================================= Hits 3283 3283
Misses 599 599
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update acf07a6...f30d9da. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Update janus requirement from <0.6,>=0.4 to >=0.4,<0.7 719381863  
706845950 https://github.com/simonw/datasette/issues/690#issuecomment-706845950 https://api.github.com/repos/simonw/datasette/issues/690 MDEyOklzc3VlQ29tbWVudDcwNjg0NTk1MA== simonw 9599 2020-10-12T04:07:28Z 2020-10-12T04:07:28Z OWNER

Next step is to design where these will go and what they will look like - in particular the navigation links that lead to plugins such as datasette-upload-csvs and datasette-configure-fts and datasette-edit-schema.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Mechanism for plugins to add action menu items for various things 573755726  
706828375 https://github.com/simonw/datasette/issues/1016#issuecomment-706828375 https://api.github.com/repos/simonw/datasette/issues/1016 MDEyOklzc3VlQ29tbWVudDcwNjgyODM3NQ== simonw 9599 2020-10-12T03:01:58Z 2020-10-12T03:01:58Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add a "delete" icon next to filters (in addition to "remove filter") 718953669  
706821561 https://github.com/simonw/datasette/issues/1016#issuecomment-706821561 https://api.github.com/repos/simonw/datasette/issues/1016 MDEyOklzc3VlQ29tbWVudDcwNjgyMTU2MQ== simonw 9599 2020-10-12T02:33:52Z 2020-10-12T02:33:52Z OWNER

Should this do the equivalent of clicking Apply for you? I don't think so - that wouldn't fit with how the rest of that block of controls works.

But if it makes the row vanish it may not be clear to the user that they still need to click Apply.

Easiest thing would be for it to select the "remove filter" column and blank out the boxes. I will try that first.

The code can go in table.js.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Add a "delete" icon next to filters (in addition to "remove filter") 718953669  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);