Blocked awaiting #1036 (update: now unblocked)

Codecov Report

Merging #1040 into main will increase coverage by 0.10%. The diff coverage is 100.00%.

```diff @@ Coverage Diff @@

main #1040 +/-

========================================== + Coverage 84.65% 84.76% +0.10%
========================================== Files 28 28
Lines 3924 3938 +14
========================================== + Hits 3322 3338 +16
+ Misses 602 600 -2
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/views/index.py | 98.18% <ø> (+1.69%) | :arrow_up: | | datasette/views/special.py | 92.70% <ø> (-0.82%) | :arrow_down: | | datasette/app.py | 96.37% <100.00%> (+0.17%) | :arrow_up: | | datasette/views/base.py | 93.77% <100.00%> (ø) | | | datasette/views/table.py | 96.07% <100.00%> (+0.22%) | :arrow_up: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update bf82b3d...4f3165f. Read the comment docs.

Thanks for spotting this!

This code needs these permission checks: https://github.com/simonw/datasette/blob/bf82b3d6a605c9ddadd5fb739249dfe6defaf635/datasette/views/table.py#L911-L913

So for https://latest.datasette.io/fixtures/binary_data the BLOB download URLs would be:

https://latest.datasette.io/fixtures/-/blob/binary_data/1/data.blob - that last bit after the primary key is to indicate the data column

With these headers:

• Content-Disposition: attachment; filename="binary_data-1-data.blob"
• X-Content-Type-Options: nosniff
• Content-Type: application/binary

Another useful demo database: https://datasette-render-images-demo.datasette.io/favicons/favicons - see https://datasette-render-images-demo.datasette.io/favicons/favicons.csv

Should this work just for BLOB columns, or should it work for other columns too?

For the moment I'm going to restrict it to BLOBs, since data from other columns is available through the UI whereas BLOB columns are not.

Actually I like .blob

What should the suggested filename be?

I think something that includes the table name, primary key and the name of the column would work.

How about a file extension? I guess .binary, then let the user rename it? Or .raw.

Now live: https://latest.datasette.io/fixtures/roadside_attraction_characteristics

Codecov Report

Merging #1038 into main will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1038 +/-

======================================= Coverage 84.65% 84.65%
======================================= Files 28 28
Lines 3924 3924
======================================= Hits 3322 3322
Misses 602 602
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 66120a7...7fc0cce. Read the comment docs.

Possible URL for this: /db/table/-/blob/primary-keys - this would use the /db/table/-/ namespace proposed in #296.

This may require updates to the column action menu JavaScript too, since it was not built with scrolling sideways in mind.

Dupe of #998.

This may require updates to the column action menu JavaScript too, since it was not built with scrolling sideways in mind.

This is particularly relevant to the datasette-cluster-map plugin - the map is much nicer to use if the table itself can be scrolled.

That plugin also makes this harder to build, because the plugin inserts the map as the direct predecessor of the <table> element and hence breaks if you try to wrap that in a <div>.

Extra security idea: a blob_download_host setting which can be used to indicate a host that should be used for downloads - for example datasettestatic.com. If this setting is populated then binary downloads are served from paths on that host only, and no other Datasette URLs from that host will be served.

I think I should prioritize the facets component of this, since that could have significant performance wins while also supporting datasette-graphql.