issue_comments

Table actions

11 rows where "created_at" is on date 2020-11-12 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: updated_at (date)

author_association 2

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
726415991 https://github.com/simonw/datasette/issues/1091#issuecomment-726415991 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxNTk5MQ== simonw 9599 2020-11-12T23:59:34Z 2020-11-12T23:59:34Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726415019 https://github.com/simonw/datasette/issues/1091#issuecomment-726415019 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxNTAxOQ== simonw 9599 2020-11-12T23:56:23Z 2020-11-12T23:56:23Z OWNER

@tballison is there any chance you're running any custom templates in that installation? I'm really confused as to why I can't replicate the bug.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726413829 https://github.com/simonw/datasette/issues/1091#issuecomment-726413829 https://api.github.com/repos/simonw/datasette/issues/1091 MDEyOklzc3VlQ29tbWVudDcyNjQxMzgyOQ== simonw 9599 2020-11-12T23:52:50Z 2020-11-12T23:54:16Z OWNER

Hmm... it's not just the .csv and .json export links - it's the column headings (which can be clicked to change the sort order) as well. Here's an extract of the HTML from that page: ```html

This data as json, CSV ( advanced)

<table class="rows-and-columns"> <thead> <tr> <th class="col-Link" scope="col" data-column="Link" data-column-type="" data-column-not-null="0" data-is-pk="0"> Link </th> <th class="col-rowid" scope="col" data-column="rowid" data-column-type="integer" data-column-not-null="0" data-is-pk="1"> rowid ▼ </th> <th class="col-PARSE_EXCEPTION_ID" scope="col" data-column="PARSE_EXCEPTION_ID" data-column-type="INTEGER" data-column-not-null="0" data-is-pk="0"> PARSE_EXCEPTION_ID </th> <th class="col-PARSE_EXCEPTION_DESCRIPTION" scope="col" data-column="PARSE_EXCEPTION_DESCRIPTION" data-column-type="VARCHAR(128)" data-column-not-null="0" data-is-pk="0"> PARSE_EXCEPTION_DESCRIPTION </th> </tr> </thead> <tbody> <tr> <td class="col-Link type-pk"> 1 </td> <td class="col-rowid type-int">1</td> <td class="col-PARSE_EXCEPTION_ID type-int">0</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">RUNTIME</td> </tr> <tr> <td class="col-Link type-pk"> 2 </td> <td class="col-rowid type-int">2</td> <td class="col-PARSE_EXCEPTION_ID type-int">1</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">ENCRYPTION</td> </tr> <tr> <td class="col-Link type-pk"> 3 </td> <td class="col-rowid type-int">3</td> <td class="col-PARSE_EXCEPTION_ID type-int">2</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">ACCESS_PERMISSION</td> </tr> <tr> <td class="col-Link type-pk"> 4 </td> <td class="col-rowid type-int">4</td> <td class="col-PARSE_EXCEPTION_ID type-int">3</td> <td class="col-PARSE_EXCEPTION_DESCRIPTION type-str">UNSUPPORTED_VERSION</td> </tr> </tbody> </table>

Advanced export

JSON shape: default, array, newline-delimited

<form action="/corpora-metadata/REF_PARSE_EXCEPTION_TYPES.csv" method="get">

CSV options: <label> download file </label>

</form>

But here's something _really_ weird - the links to the individual rows DO include the `/datasette/` prefix:html

<td class="col-Link type-pk"> 2 </td>

The navigation bar on that page is correct too:html

home / corpora-metadata

`` I've also been unable to replicate this in my own local environment, runningdatasette fixtures.db --config base_url:/datasette/`.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 .json and .csv exports fail to apply base_url 742011049  
726412057 https://github.com/simonw/datasette/issues/865#issuecomment-726412057 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcyNjQxMjA1Nw== simonw 9599 2020-11-12T23:49:23Z 2020-11-12T23:49:23Z OWNER

@tballison thanks, I've split that out into a new issue #1091

 
{
    "total_count": 1,
    "+1": 1,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
726385782 https://github.com/simonw/datasette/issues/865#issuecomment-726385782 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcyNjM4NTc4Mg== tballison 6739646 2020-11-12T22:41:06Z 2020-11-12T22:41:06Z NONE

The same is true if I select advanced export and hit the 'export csv' at the bottom of the page.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
726385422 https://github.com/simonw/datasette/issues/865#issuecomment-726385422 https://api.github.com/repos/simonw/datasette/issues/865 MDEyOklzc3VlQ29tbWVudDcyNjM4NTQyMg== tballison 6739646 2020-11-12T22:40:14Z 2020-11-12T22:40:14Z NONE

Just tested with the latest Docker image, and it works pretty much everywhere! THANK YOU!

I did notice that if I try to export json or csv, the base is not applied. Not sure if I should reopen this issue or open a new one.

To see this, go here: https://corpora.tika.apache.org/datasette/corpora-metadata/REF_PARSE_EXCEPTION_TYPES

Click/hover over json or CSV and you'll see that the 'datasette' base is not included.

Again, many thanks!

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 base_url doesn't seem to work when adding criteria and clicking "apply" 644582921  
726127465 https://github.com/simonw/datasette/issues/1089#issuecomment-726127465 https://api.github.com/repos/simonw/datasette/issues/1089 MDEyOklzc3VlQ29tbWVudDcyNjEyNzQ2NQ== simonw 9599 2020-11-12T14:54:11Z 2020-11-12T14:54:11Z OWNER

Suggested list to look out for from that PR:

  • simply/simple
  • easy/easier/easiest
  • obvious/obviously
  • just
  • merely
  • straightforward
  • ridiculous
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Sweep documentation for words that minimize involved difficulty 741665726  
725830716 https://github.com/simonw/datasette/issues/1088#issuecomment-725830716 https://api.github.com/repos/simonw/datasette/issues/1088 MDEyOklzc3VlQ29tbWVudDcyNTgzMDcxNg== simonw 9599 2020-11-12T04:35:38Z 2020-11-12T04:35:38Z OWNER

I'm going to fix this without a test, because writing a test for this is a bit fiddly and it's a very minor bug. If it comes back again I'll do the work to test for it.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 OperationalError('interrupted') can 500 on row page 741268956  
725830533 https://github.com/simonw/datasette/issues/1088#issuecomment-725830533 https://api.github.com/repos/simonw/datasette/issues/1088 MDEyOklzc3VlQ29tbWVudDcyNTgzMDUzMw== simonw 9599 2020-11-12T04:35:08Z 2020-11-12T04:35:08Z OWNER

Yup, swapping QueryInterrupted fixed this against my giant database.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 OperationalError('interrupted') can 500 on row page 741268956  
725829903 https://github.com/simonw/datasette/issues/1088#issuecomment-725829903 https://api.github.com/repos/simonw/datasette/issues/1088 MDEyOklzc3VlQ29tbWVudDcyNTgyOTkwMw== simonw 9599 2020-11-12T04:33:14Z 2020-11-12T04:33:14Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 OperationalError('interrupted') can 500 on row page 741268956  
725731685 https://github.com/simonw/datasette/pull/1085#issuecomment-725731685 https://api.github.com/repos/simonw/datasette/issues/1085 MDEyOklzc3VlQ29tbWVudDcyNTczMTY4NQ== codecov[bot] 22429695 2020-11-12T00:01:18Z 2020-11-12T00:01:18Z NONE

Codecov Report

Merging #1085 (51e7651) into main (2a981e2) will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #1085 +/-

======================================= Coverage 91.38% 91.38%
======================================= Files 30 30
Lines 3785 3785
======================================= Hits 3459 3459
Misses 326 326
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 2a981e2...51e7651. Read the comment docs.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Use FTS4 in fixtures 740512882  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);