issue_comments

Table actions

2 rows where "created_at" is on date 2021-02-18, issue = 811367257 and "updated_at" is on date 2021-02-18 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Race condition errors in new refresh_schemas() mechanism · 2 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
781560989 https://github.com/simonw/datasette/issues/1231#issuecomment-781560989 https://api.github.com/repos/simonw/datasette/issues/1231 MDEyOklzc3VlQ29tbWVudDc4MTU2MDk4OQ== simonw 9599 2021-02-18T18:50:53Z 2021-02-18T18:50:53Z OWNER

Ideally I'd figure out a way to replicate this error in a concurrent unit test.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Race condition errors in new refresh_schemas() mechanism 811367257  
781560865 https://github.com/simonw/datasette/issues/1231#issuecomment-781560865 https://api.github.com/repos/simonw/datasette/issues/1231 MDEyOklzc3VlQ29tbWVudDc4MTU2MDg2NQ== simonw 9599 2021-02-18T18:50:38Z 2021-02-18T18:50:38Z OWNER

I started trying to use locks to resolve this but I've not figured out the right way to do that yet - here's my first experiment: ```diff diff --git a/datasette/app.py b/datasette/app.py index 9e15a16..1681c9d 100644 --- a/datasette/app.py +++ b/datasette/app.py @@ -217,6 +217,7 @@ class Datasette: self.inspect_data = inspect_data self.immutables = set(immutables or []) self.databases = collections.OrderedDict() + self._refresh_schemas_lock = threading.Lock() if memory or not self.files: self.add_database(Database(self, is_memory=True), name="_memory") # memory_name is a random string so that each Datasette instance gets its own @@ -324,6 +325,13 @@ class Datasette: self.client = DatasetteClient(self)

 async def refresh_schemas(self):
  • return
  • if self._refresh_schemas_lock.locked():
  • return
  • with self._refresh_schemas_lock:
  • await self._refresh_schemas() +
  • async def _refresh_schemas(self): internal_db = self.databases["_internal"] if not self.internal_db_created: await init_internal_db(internal_db) ```
 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Race condition errors in new refresh_schemas() mechanism 811367257  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);