Codecov Report

Merging #1463 (2dd94c5) into main (0d5cc20) will decrease coverage by 0.00%. The diff coverage is n/a.

:exclamation: Current head 2dd94c5 differs from pull request most recent head 481212c. Consider uploading reports for the commit 481212c to get more accurate results

```diff @@ Coverage Diff @@

main #1463 +/-

========================================== - Coverage 91.83% 91.83% -0.01%
========================================== Files 34 34
Lines 4422 4421 -1
========================================== - Hits 4061 4060 -1
Misses 361 361
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/views/table.py | 96.00% <0.00%> (-0.01%) | :arrow_down: |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e1012e7...481212c. Read the comment docs.

Thanks, that does look similar!

Unfortunately, pysqlite3-binary isn't available for Mac OS X, so I can't quickly check that that fixes it; will do so later.

Ah that makes sense, I guess that's why this isn't just always installed already. I wonder if a possible solution to this issue could be doing feature detection on whether this feature is supported by the current Sqlite version, and if not these tests could be disabled locally? But possibly there's a better way to handle this, will see what @simonw thinks

Codecov Report

Merging #326 (078a087) into main (77c240d) will not change coverage. The diff coverage is n/a.

```diff @@ Coverage Diff @@

main #326 +/-

======================================= Coverage 96.58% 96.58%
======================================= Files 5 5
Lines 2223 2223
======================================= Hits 2147 2147
Misses 76 76
```

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 77c240d...078a087. Read the comment docs.

thanks for the response! full errors attached; excerpt:

``` ...

def test_searchmode(table_metadata, querystring, expected_rows):
    with make_app_client(
        metadata={"databases": {"fixtures": {"tables": {"searchable": table_metadata}}}}
    ) as client:
        response = client.get("/fixtures/searchable.json?" + querystring)

      assert expected_rows == response.json["rows"]

E AssertionError: assert [[1, 'barry c...sel', 'puma']] == [] E Left contains 2 more items, first extra item: [1, 'barry cat', 'terry dog', 'panther'] E Use -v to get the full diff

/Users/t/dev/datasette/tests/test_api.py:1115: AssertionError ```

errors.txt

A quick scan of #1223 suggests you're right. Unfortunately, pysqlite3-binary isn't available for Mac OS X, so I can't quickly check that that fixes it; will do so later.

What are the full errors you're getting?

This may be the same issue as described in https://github.com/simonw/datasette/pull/1223 - essentially the test suite (and corresponding Datasette features I assume) are by default implicitly dependent on your Sqlite installation having been compiled with the SQLITE_ENABLE_FTS3_PARENTHESIS option. If this is the same issue then I think this can be fixed either by recompiling with that option or (probably more easily) by running pip install pysqlite3-binary, which will be used in preference to your system Sqlite installation and has this option enabled.

on commit d57ab156b35ec642