issue_comments

Table actions

7 rows where "created_at" is on date 2022-03-17 and "updated_at" is on date 2022-03-17 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: issue_url, body, created_at (date), updated_at (date)

user 1

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1071813296 https://github.com/simonw/datasette/pull/1664#issuecomment-1071813296 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_4pKw simonw 9599 2022-03-17T23:26:22Z 2022-03-17T23:26:22Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1071809988 https://github.com/simonw/datasette/pull/1664#issuecomment-1071809988 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_4oXE simonw 9599 2022-03-17T23:24:57Z 2022-03-17T23:24:57Z OWNER

My hunch is that this is broken because of this:

https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/app.py#L1098-L1107

Note how the table uses table_and_format but the row uses just table - I think there's code that's getting confused by this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1071803114 https://github.com/simonw/datasette/pull/1664#issuecomment-1071803114 https://api.github.com/repos/simonw/datasette/issues/1664 IC_kwDOBm6k_c4_4mrq simonw 9599 2022-03-17T23:22:00Z 2022-03-17T23:22:00Z OWNER

Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove hashed URL mode 1173017980  
1071797707 https://github.com/simonw/datasette/issues/1661#issuecomment-1071797707 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_4lXL simonw 9599 2022-03-17T23:19:24Z 2022-03-17T23:19:24Z OWNER

Moving this to PR so I can comment on individual lines: - #1664

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove Hashed URL mode 1170355774  
1071793307 https://github.com/simonw/datasette/issues/1661#issuecomment-1071793307 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_4kSb simonw 9599 2022-03-17T23:17:32Z 2022-03-17T23:17:32Z OWNER

Surprisingly I managed to break https://latest.datasette.io/fixtures/custom_foreign_key_label while working on this change:

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove Hashed URL mode 1170355774  
1071706993 https://github.com/simonw/datasette/issues/1661#issuecomment-1071706993 https://api.github.com/repos/simonw/datasette/issues/1661 IC_kwDOBm6k_c4_4PNx simonw 9599 2022-03-17T22:42:21Z 2022-03-17T22:42:21Z OWNER

As part of this I'm going to get rid of this mechanism: https://github.com/simonw/datasette/blob/30e5f0e67c38054a8087a2a4eae3fc4d1779af90/datasette/views/base.py#L170-L173

Unwrapping request.scope["url_route"]["kwargs"] into keyword argument to view functions just made the code harder to follow.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Remove Hashed URL mode 1170355774  
1071519407 https://github.com/simonw/datasette/issues/1663#issuecomment-1071519407 https://api.github.com/repos/simonw/datasette/issues/1663 IC_kwDOBm6k_c4_3hav simonw 9599 2022-03-17T21:32:35Z 2022-03-17T21:32:35Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Document the internals that were used in datasette-hashed-urls 1170554975  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);