issue_comments

Table actions

4 rows where "created_at" is on date 2023-08-23 and issue = 459509126 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Enforce import sort order with isort · 4 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
1689159200 https://github.com/simonw/datasette/issues/516#issuecomment-1689159200 https://api.github.com/repos/simonw/datasette/issues/516 IC_kwDOBm6k_c5kroYg simonw 9599 2023-08-23T02:15:36Z 2023-08-23T02:15:36Z OWNER

This could play havoc with unmerged PRs. I should merge any big ones (like the JavaScript plugins work) first.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  
1689158712 https://github.com/simonw/datasette/issues/516#issuecomment-1689158712 https://api.github.com/repos/simonw/datasette/issues/516 IC_kwDOBm6k_c5kroQ4 simonw 9599 2023-08-23T02:14:45Z 2023-08-23T02:14:45Z OWNER

Thinking about this again today. Posted about it on Discord: https://discord.com/channels/823971286308356157/823971286941302908/1143729300349132933

I won't enforce it in a pytest test, I'll enforce it with a CI lint check that's also in the Justfile here instead:

https://github.com/simonw/datasette/blob/17ec309e14f9c2e90035ba33f2f38ecc5afba2fa/Justfile#L19-L23

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  
1689154837 https://github.com/simonw/datasette/issues/516#issuecomment-1689154837 https://api.github.com/repos/simonw/datasette/issues/516 IC_kwDOBm6k_c5krnUV simonw 9599 2023-08-23T02:08:33Z 2023-08-23T02:08:50Z OWNER 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  
1689153446 https://github.com/simonw/datasette/issues/516#issuecomment-1689153446 https://api.github.com/repos/simonw/datasette/issues/516 IC_kwDOBm6k_c5krm-m simonw 9599 2023-08-23T02:06:35Z 2023-08-23T02:06:35Z OWNER

I just tried this again today by dropping this into .isort.cfg: ini [settings] multi_line_output=3 include_trailing_comma=True force_grid_wrap=0 use_parentheses=True line_length=88 known_first_party=datasette And running this in the root of the project: isort . It produced a huge diff, but when I ran the tests: bash pytest -n auto The tests all passed. I'll push a PR.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Enforce import sort order with isort 459509126  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);