issue_comments

Table actions

5 rows where issue = 1025754125 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

issue 1

  • Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
942782673 https://github.com/simonw/datasette/issues/1488#issuecomment-942782673 https://api.github.com/repos/simonw/datasette/issues/1488 IC_kwDOBm6k_c44MbjR simonw 9599 2021-10-13T23:04:54Z 2021-10-13T23:04:54Z OWNER

I think this is the change in httpx which is causing the bug for me: https://github.com/encode/httpx/commit/ff9813e84dab56f0f3c4ef3a159a4cce8c644a91#diff-0d0cbe9ebcd03cc8c780b0407762540a082f70cc64257f2fcd588cc30f43c15cR96

Previously it was using path from path, _, query = full_path.partition(b"?") to populate the raw_path key - but it changed to instead using request.url.raw_path which presumably implements the logic that includes the query string.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125  
942779926 https://github.com/simonw/datasette/issues/1488#issuecomment-942779926 https://api.github.com/repos/simonw/datasette/issues/1488 IC_kwDOBm6k_c44Ma4W simonw 9599 2021-10-13T22:59:05Z 2021-10-13T22:59:05Z OWNER

This is weird - as far as I can tell httpx has included the query string in raw_path for well over a year: https://github.com/encode/httpx/commit/8e4a8a1c73f60fe5754f95b308beaa725cb8791d#diff-c9a78eb3b5f5c4fac4e5552165fbdd5320c7e3fadf9eedabcb5461393466c090R235

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125  
942778673 https://github.com/simonw/datasette/issues/1488#issuecomment-942778673 https://api.github.com/repos/simonw/datasette/issues/1488 IC_kwDOBm6k_c44Makx simonw 9599 2021-10-13T22:55:44Z 2021-10-13T22:55:44Z OWNER

(Pdb) request.scope['path'] '/_memory.json' (Pdb) request.scope['raw_path'] b'/_memory.json?sql=select+sqlite_version()' So raw_path now includes the query string.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125  
942778382 https://github.com/simonw/datasette/issues/1488#issuecomment-942778382 https://api.github.com/repos/simonw/datasette/issues/1488 IC_kwDOBm6k_c44MagO simonw 9599 2021-10-13T22:55:01Z 2021-10-13T22:55:01Z OWNER

I think the issue is in route_path(): ```

/Users/simon/Dropbox/Development/datasette/datasette/app.py(1182)route_path() -> response = await view(request, send) (Pdb) path '/_memory.json?sql=select+sqlite_version()' ```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125  
942777414 https://github.com/simonw/datasette/issues/1488#issuecomment-942777414 https://api.github.com/repos/simonw/datasette/issues/1488 IC_kwDOBm6k_c44MaRG simonw 9599 2021-10-13T22:52:40Z 2021-10-13T22:52:40Z OWNER

Upgrading to 0.20.0 gives me lots of the following errors:

'{"ok": false, "error": "Database not found: .json?_sort=relationships", "status": 404, "title": null}'

It looks like the full query string is now being treated as the name of the database.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Upgrade to httpx 0.20.0 (request() got an unexpected keyword argument 'allow_redirects') 1025754125  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);