issue_comments

Table actions

5 rows where issue = 1033678984 sorted by updated_at descending

✖
✖

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 3

author_association 2

issue 1

  • Allow routes to have extra options · 5 ✖
id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
974108455 https://github.com/simonw/datasette/pull/1495#issuecomment-974108455 https://api.github.com/repos/simonw/datasette/issues/1495 IC_kwDOBm6k_c46D7cn mroswell 192568 2021-11-19T14:14:35Z 2021-11-19T14:14:35Z CONTRIBUTOR

A nudge on this.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow routes to have extra options 1033678984  
960420237 https://github.com/simonw/datasette/pull/1495#issuecomment-960420237 https://api.github.com/repos/simonw/datasette/issues/1495 IC_kwDOBm6k_c45PtmN mroswell 192568 2021-11-04T03:12:01Z 2021-11-04T03:12:01Z CONTRIBUTOR

This all looks promising! I will need detailed documentation on how to upgrade datasette once it's available, and how to implement. (@fgregg example looks very straightforward on the plugin front.) I'll be so excited if I can get: https://list.saferdisinfectants.org/ instead of https://list.saferdisinfectants.org/disinfectants/listN

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow routes to have extra options 1033678984  
954384496 https://github.com/simonw/datasette/pull/1495#issuecomment-954384496 https://api.github.com/repos/simonw/datasette/issues/1495 IC_kwDOBm6k_c444sBw fgregg 536941 2021-10-29T03:07:13Z 2021-10-29T03:07:13Z CONTRIBUTOR

okay @simonw, made the requested changes. tests are running locally. i think this is ready for you to look at again.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow routes to have extra options 1033678984  
950403692 https://github.com/simonw/datasette/pull/1495#issuecomment-950403692 https://api.github.com/repos/simonw/datasette/issues/1495 IC_kwDOBm6k_c44pgJs simonw 9599 2021-10-24T22:10:43Z 2021-10-24T22:10:43Z OWNER

To land this change we'll need a unit test that demonstrates the new capability - I suggest putting that next to this test: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/tests/test_plugins.py#L648-L659

It will also need documentation, which should be added here: https://github.com/simonw/datasette/blob/15a9d4abfff0c45dee2a9f851326e1d61b1c678c/docs/plugin_hooks.rst#register-routes-datasette

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow routes to have extra options 1033678984  
950403521 https://github.com/simonw/datasette/pull/1495#issuecomment-950403521 https://api.github.com/repos/simonw/datasette/issues/1495 IC_kwDOBm6k_c44pgHB simonw 9599 2021-10-24T22:09:18Z 2021-10-24T22:09:18Z OWNER

This is a great idea - I've wanted this myself before, but never spent any time thinking about how to achieve it.

I think your design here is exactly right - an optional third item in the tuple consisting of a dictionary of options to pass to the view function.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Allow routes to have extra options 1033678984  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);