Codecov Report

Merging #1512 (8f757da) into main (0156c6b) will decrease coverage by 2.10%. The diff coverage is 36.20%.

```diff @@ Coverage Diff @@

main #1512 +/-

========================================== - Coverage 91.82% 89.72% -2.11%
========================================== Files 34 36 +2
Lines 4430 4604 +174
========================================== + Hits 4068 4131 +63
- Misses 362 473 +111
```

| Impacted Files | Coverage Δ | | |---|---|---| | datasette/utils/vendored_graphlib.py | 0.00% <0.00%> (ø) | | | datasette/utils/asyncdi.py | 96.92% <96.92%> (ø) | |

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0156c6b...8f757da. Read the comment docs.

I made the changes locally and tested them with Python 3.6 like so: cd /tmp mkdir v cd v pipenv shell --python=python3.6 cd ~/Dropbox/Development/datasette pip install -e '.[test]' pytest tests/test_asyncdi.py

E File "/home/runner/work/datasette/datasette/datasette/utils/vendored_graphlib.py", line 56 E if (result := self._node2info.get(node)) is None: E ^ E SyntaxError: invalid syntax Oh no - the vendored code I use has := so doesn't work on Python 3.6! Will have to backport it more thoroughly.

I've decided to make the clever asyncio dependency injection opt-in - so you can either decorate with @inject or you can set inject_all = True on the class - for example: ```python import asyncio from datasette.utils.asyncdi import AsyncBase, inject

class Simple(AsyncBase): def init(self): self.log = []

@inject
async def two(self):
    self.log.append("two")

@inject
async def one(self, two):
    self.log.append("one")
    return self.log

async def not_inject(self, one, two):
    return one + two

class Complex(AsyncBase): inject_all = True

def __init__(self):
    self.log = []

async def b(self):
    self.log.append("b")

async def a(self, b):
    self.log.append("a")

async def go(self, a):
    self.log.append("go")
    return self.log

```