issue_comments

Table actions

5 rows where issue = 1066563554 and user = 9599 sorted by updated_at descending

✎ View and edit SQL

This data as json, CSV (advanced)

Suggested facets: created_at (date), updated_at (date)

user 1

  • simonw · 5 ✖

issue 1

  • Way to test SQLite 3.37 (and potentially other versions) in CI · 5 ✖

author_association 1

id html_url issue_url node_id user created_at updated_at ▲ author_association body reactions issue performed_via_github_app
982111751 https://github.com/simonw/sqlite-utils/issues/346#issuecomment-982111751 https://api.github.com/repos/simonw/sqlite-utils/issues/346 IC_kwDOCGYnMM46idYH simonw 9599 2021-11-29T23:11:17Z 2021-11-29T23:12:49Z OWNER

To keep things simple for the moment I'm only going to add one extra thing to the matrix, and it will be a run of the tests against SQLite 3.37.0 using pysqlite3 on Linux only.

I can use this mechanism: https://docs.github.com/en/actions/learn-github-actions/workflow-syntax-for-github-actions#example-including-new-combinations

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to test SQLite 3.37 (and potentially other versions) in CI 1066563554  
982094370 https://github.com/simonw/sqlite-utils/issues/346#issuecomment-982094370 https://api.github.com/repos/simonw/sqlite-utils/issues/346 IC_kwDOCGYnMM46iZIi simonw 9599 2021-11-29T22:50:49Z 2021-11-29T22:50:49Z OWNER

I have a working recipe for compiling it for macOS here: https://github.com/simonw/sqlite-utils/issues/344#issuecomment-982006544

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to test SQLite 3.37 (and potentially other versions) in CI 1066563554  
982094020 https://github.com/simonw/sqlite-utils/issues/346#issuecomment-982094020 https://api.github.com/repos/simonw/sqlite-utils/issues/346 IC_kwDOCGYnMM46iZDE simonw 9599 2021-11-29T22:50:11Z 2021-11-29T22:50:11Z OWNER

For the moment I think I'll combine two problems into one, and just add a single matrix alternative that uses pysqlite3 running SQLite 3.37.0 - only on macOS and Linux so I don't have to figure out how to compile it for Windows.

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to test SQLite 3.37 (and potentially other versions) in CI 1066563554  
982078527 https://github.com/simonw/sqlite-utils/issues/346#issuecomment-982078527 https://api.github.com/repos/simonw/sqlite-utils/issues/346 IC_kwDOCGYnMM46iVQ_ simonw 9599 2021-11-29T22:23:03Z 2021-11-29T22:23:03Z OWNER

Here's a modified version of the dump command that works even with pysqlite3:

```python @cli.command() @click.argument( "path", type=click.Path(exists=True, file_okay=True, dir_okay=False, allow_dash=False), required=True, ) @load_extension_option def dump(path, load_extension): """Output a SQL dump of the schema and full contents of the database""" db = sqlite_utils.Database(path) _load_extensions(db, load_extension) # pysqlite3 doesn't implement .iterdump() from sqlite3.dump import _iterdump

for line in _iterdump(db.conn):
    click.echo(line)

```

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to test SQLite 3.37 (and potentially other versions) in CI 1066563554  
982077873 https://github.com/simonw/sqlite-utils/issues/346#issuecomment-982077873 https://api.github.com/repos/simonw/sqlite-utils/issues/346 IC_kwDOCGYnMM46iVGx simonw 9599 2021-11-29T22:22:05Z 2021-11-29T22:22:05Z OWNER

Ideally I'd like an extra set of matrix options for different versions of SQLite.

I can use pysqlite3 for this, but it isn't a completely compatible drop-in replacement - turns out it doesn't support the iterdump() method for example, see https://github.com/coleifer/pysqlite3/issues/24

 
{
    "total_count": 0,
    "+1": 0,
    "-1": 0,
    "laugh": 0,
    "hooray": 0,
    "confused": 0,
    "heart": 0,
    "rocket": 0,
    "eyes": 0
}
 Way to test SQLite 3.37 (and potentially other versions) in CI 1066563554  

Advanced export

JSON shape: default, array, newline-delimited, object

CSV options: 

CREATE TABLE [issue_comments] (
   [html_url] TEXT,
   [issue_url] TEXT,
   [id] INTEGER PRIMARY KEY,
   [node_id] TEXT,
   [user] INTEGER REFERENCES [users]([id]),
   [created_at] TEXT,
   [updated_at] TEXT,
   [author_association] TEXT,
   [body] TEXT,
   [reactions] TEXT,
   [issue] INTEGER REFERENCES [issues]([id])
, [performed_via_github_app] TEXT);
CREATE INDEX [idx_issue_comments_issue]
                ON [issue_comments] ([issue]);
CREATE INDEX [idx_issue_comments_user]
                ON [issue_comments] ([user]);